The Wayback Machine - https://web.archive.org/web/20210124105417/https://github.com/sql-js/sql.js/issues/354
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

literal strings are thrown on errors instead of Error objects #354

Open
lovasoa opened this issue Feb 29, 2020 · 0 comments
Open

literal strings are thrown on errors instead of Error objects #354

lovasoa opened this issue Feb 29, 2020 · 0 comments
Labels

Comments

@lovasoa
Copy link
Member

@lovasoa lovasoa commented Feb 29, 2020

It is considered good practice to only throw the Error object itself or an object using the Error object as base objects for user-defined exceptions. The fundamental benefit of Error objects is that they automatically keep track of where they were built and originated.

This would be a breaking change, but should not impact many users.

@lovasoa lovasoa added the enhancement label Feb 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant