The Wayback Machine - https://web.archive.org/web/20210711100035/https://github.com/Kong/kong/issues/2054
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass consumer_id as a tag in Datadog plugin #2054

Open
cknowles opened this issue Feb 8, 2017 · 4 comments
Open

Pass consumer_id as a tag in Datadog plugin #2054

cknowles opened this issue Feb 8, 2017 · 4 comments

Comments

@cknowles
Copy link

@cknowles cknowles commented Feb 8, 2017

A follow up to #998. Inside the Datadog plugin, would it be possible to add an option to place the consumer_id inside a dogstatsd tag rather than the metric name? The advantage is that this makes it easier in Datadog to do things like plot the top 10 API users or worst performing APIs. So an option meaning kong.<api_name>.request.count would end up having a dogstatsd tag with the consumer_id.

This could easily be extended to all the other metrics, for example adding this tag to kong.<api_name>.<http_status_code>.count would mean it could also be broken down by response code. We could even go as far as putting the response code in a tag as well so kong.<api_name>.response.count would come through tagged with the response code, this would provide similar capability but the pivot would be on response code.

@p0pr0ck5
Copy link
Contributor

@p0pr0ck5 p0pr0ck5 commented Apr 18, 2017

@shashiranjan84 curious, is this handled or addressed in #2394 per chance?

@shashiranjan84
Copy link
Contributor

@shashiranjan84 shashiranjan84 commented Apr 18, 2017

@p0pr0ck5 no, Current changes only allow static tags

@p0pr0ck5
Copy link
Contributor

@p0pr0ck5 p0pr0ck5 commented Apr 28, 2017

This likely won't be something we will be able to work on in the short term. Community patches and contributions welcome!

@mathematician
Copy link

@mathematician mathematician commented Apr 2, 2018

Any update on this capability?

mathematician added a commit to mathematician/kong that referenced this issue Apr 6, 2018
- Every request_count metric will include a consumer_id tag if available
- Update datadog request_count schema to include consumer_identifier
- Update datadog request_count migrations to include consumer_identifier
- Update tests to include tag if consumer is used

Related issue: Kong#2054
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants