The Wayback Machine - https://web.archive.org/web/20210815143342/https://github.com/authelia/authelia/issues/1337
Skip to content

/ authelia

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add primary keys to SQL tables for percona/galera support #1337

Open
Ornias1993 opened this issue Sep 23, 2020 · 4 comments
Open

Add primary keys to SQL tables for percona/galera support #1337

Ornias1993 opened this issue Sep 23, 2020 · 4 comments
Labels
Feature Request Good First Issue P3
Milestone
v4.31.0

Comments

@Ornias1993
Copy link

@Ornias1993 Ornias1993 commented Sep 23, 2020 •
edited

Percona is quite strict on having primary keys on all tables (and rightly so).
Please add primary keys to all tables, even if it's just an auto-increment.

It's mostly just the following tables:
authentication_logs (could just get a auto-increment primary key added)
identity_verification_tokens (could just set the token as primary key)
@james-d-elliott
Copy link
Member

@james-d-elliott james-d-elliott commented Oct 23, 2020

This is definitely something we can do. We have a plan to make some changes to the DB schema shortly so I will try to squeeze that in then.
@Ornias1993
Copy link
Author

@Ornias1993 Ornias1993 commented Oct 23, 2020

@james-d-elliott Awesome.
I did some initial tests by manually adding those colums and it worked out just fine btw :)
@james-d-elliott
Copy link
Member

@james-d-elliott james-d-elliott commented Oct 23, 2020

Yeah making them primary should be fine, it's just making sure everyone is on the same schema state when we do it. That way there is no desync.
@Ornias1993
Copy link
Author

@Ornias1993 Ornias1993 commented Oct 23, 2020

Yeah the migration is the most work indeed 👍
Thanks for picking it up! :)
@james-d-elliott james-d-elliott added this to the v4.28.0 milestone Feb 2, 2021
@james-d-elliott james-d-elliott removed this from the v4.28.0 milestone Apr 14, 2021
@james-d-elliott james-d-elliott added this to the v4.30.0 milestone Apr 14, 2021
@james-d-elliott james-d-elliott removed this from the v4.30.0 milestone Jun 12, 2021
@james-d-elliott james-d-elliott added this to the v4.32.0 milestone Jun 12, 2021
@james-d-elliott james-d-elliott removed this from the v4.32.0 milestone Jun 12, 2021
@james-d-elliott james-d-elliott added this to the v4.30.0 milestone Jun 12, 2021
@james-d-elliott james-d-elliott removed this from the v4.30.0 milestone Jun 12, 2021
@james-d-elliott james-d-elliott added this to the v4.31.0 milestone Jun 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Request Good First Issue P3
Projects
None yet
Milestone
v4.31.0
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@nightah @james-d-elliott @Ornias1993