The Wayback Machine - https://web.archive.org/web/20201229165351/https://github.com/swagger-api/swagger-editor/pull/2209
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(build): es2015 bundle artifact #2209

Merged
merged 7 commits into from Aug 21, 2020
Merged

Conversation

@tim-lai
Copy link
Contributor

@tim-lai tim-lai commented Aug 21, 2020

Description

  • es2015 bundle with dependencies via npm script build:es:bundle
  • es2015 bundle without dependencies via npm script build:es:bundle:core
  • migrate babel.config.json to babel.config.js and maintain env support for commonjs and es2015
  • jest dependency for test:artifact
  • update .npmignore to include new production bundles

Motivation and Context

swagger-editor should be available as an es2015 bundle.

How Has This Been Tested?

New Jest tests to confirm that production bundles export as a function.

Note: known issue that these Jest tests pass locally on Node 10/12/13, but not on Jenkins. As a result, test:artifact is not currently included in the test script.

Screenshots (if appropriate):

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.
@tim-lai tim-lai merged commit 687270a into swagger-api:master Aug 21, 2020
1 check passed
1 check passed
Jenkins Insolent Mammal! It passed. Now bite my shiny metal ass!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.