The Wayback Machine - https://web.archive.org/web/20201229165401/https://github.com/swagger-api/swagger-editor/pull/2219
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate unit tests to Jest #2219

Merged
merged 23 commits into from Aug 27, 2020

Conversation

@tim-lai
Copy link
Contributor

@tim-lai tim-lai commented Aug 27, 2020

Description

  • Migrate most Mocha-based unit tests to Jest
  • Move non-migrated Mocha tests from /test/unit to test/mocha. It's really just 1 test file, plus a helper mock file.
  • Add eslint-plugin-jest, specifically for jest/globals lint rule
  • Add test/unit/.eslintrc that includes updated semi and quotes` lint rules
  • Update package test script names for clarity, and update documentation accordingly

Note: The WIP non-migrated Mocha test remains, but is skipped for Jest.

Motivation and Context

Recent feature: es2105 artifacts introduced Jest test environment. This PR continues the migration from Mocha to Jest.

How Has This Been Tested?

These tests pass. :)

Test Suites: 1 skipped, 30 passed, 30 of 31 total
Tests:       23 skipped, 434 passed, 457 total
Snapshots:   0 total
Time:        16.554 s

Screenshots (if appropriate):

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.
@tim-lai tim-lai changed the title Feat/jest unit test migrate feat: migrate unit tests to Jest Aug 27, 2020
@tim-lai tim-lai merged commit dfaf796 into swagger-api:master Aug 27, 2020
1 check passed
1 check passed
Jenkins Insolent Mammal! It passed. Now bite my shiny metal ass!
Details
@tim-lai tim-lai mentioned this pull request Aug 27, 2020
4 of 17 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.