The Wayback Machine - https://web.archive.org/web/20220514103755/https://github.com/bottlepy/bottle/pull/1301
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cosmetic improvement #1301

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

cosmetic improvement #1301

wants to merge 1 commit into from

Conversation

SergBobrovsky
Copy link
Contributor

@SergBobrovsky SergBobrovsky commented Jan 3, 2021

No description provided.

@Jwink3101
Copy link

@Jwink3101 Jwink3101 commented Jan 3, 2021

I have no say in the matter but I think importing functions from a module goes against the "Zen of Python". Keep them in their own name space!

@SergBobrovsky
Copy link
Contributor Author

@SergBobrovsky SergBobrovsky commented Jan 3, 2021 •
edited

I have no say in the matter but I think importing functions from a module goes against the "Zen of Python". Keep them in their own name space!

@Jwink3101 I believe that b64encode and b64decode are very specific words to cause names conflicts.
How do you rate this:

from unicodedata import normalize

RonRothman
RonRothman approved these changes Jan 5, 2021
View changes
Copy link

@RonRothman RonRothman left a comment

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RonRothman RonRothman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SergBobrovsky @Jwink3101 @RonRothman