The Wayback Machine - https://web.archive.org/web/20250626174440/https://github.com/python/cpython/pull/27320
Skip to content

Fix 404 link to the pyporting mailing list #27320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 4, 2021
Merged

Fix 404 link to the pyporting mailing list #27320

merged 4 commits into from
Aug 4, 2021

Conversation

rohitnishad613
Copy link
Contributor

https://mail.python.org/mailman/listinfo/python-porting this link is broken and return 404 error. So i just removed it.
Also, this page is about proting code so i linked out to my own python converter tool. (Its not a paid tool)

@rohitnishad613
Remove 404 Page link
e43715b 
https://mail.python.org/mailman/listinfo/python-porting this link is broken and return 404 error. So i just removed it.
Also, this page is about proting code so i linked out to my own python converter tool. (Its not a paid tool)
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@rohitnishad613

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added the docs Documentation in the Doc dir label Jul 24, 2021
@rohitnishad613
Copy link
Contributor Author

rohitnishad613 commented Jul 26, 2021 •
edited
Loading

I signed PSF CA but was not added...
Is there anything wrong?

Here is the agreement I receive in my email,
https://pdfhost.io/v/Q1FP8vFB4_Contributor_Agreement_20200923_signed.pdf

@Mariatta
Copy link
Member

@rohitnishad613 You also need to create the b.p.o account, and then put in your GitHub username in the b.p.o profile.

@Mariatta
Copy link
Member

So python-porting mailing list used to exist but it was retired a couple years ago.
See the thread about it here: https://mail.python.org/archives/list/[email protected]/thread/6436V5ATEGKUGRQU5ONV27PUL2O4TMR4/

The archive is still accessible at https://mail.python.org/pipermail/python-porting/
I would simply replace the link with this one, instead of recommending a third-party tool.

Mariatta
Mariatta requested changes Jul 28, 2021
View reviewed changes
Copy link
Member

@Mariatta Mariatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer we link to the archived mailing list instead of linking to a third party tool.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@Mariatta Mariatta added needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels Jul 28, 2021
@rohitnishad613 @Mariatta
Replacing Python archived mailing
c823aa8 
Co-authored-by: Mariatta Wijaya <[email protected]>
@rohitnishad613 @Mariatta
Replacing Python archived mailing
4cb2d8f 
Co-authored-by: Mariatta Wijaya <[email protected]>
@rohitnishad613
Copy link
Contributor Author

I have made the requested changes; please review again.

Plus, I have a question I made a web tool "Python 2 to 3 converter" I think that tool is worth linking so, can I link it here?

@bedevere-bot
Copy link

Thanks for making the requested changes!

@Mariatta: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from Mariatta July 29, 2021 03:40
@ambv ambv changed the title Remove 404 Page link Fix 404 link to the pyporting mailing list Aug 4, 2021
@ambv ambv merged commit 977d99d into python:main Aug 4, 2021
@miss-islington
Copy link
Contributor

Thanks @rohitnishad613 for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 4, 2021
@rohitnishad613 @miss-islington
Fix 404 link to the pyporting mailing list (pythonGH-27320)
727ed01 
Co-authored-by: Mariatta Wijaya <[email protected]>
Co-authored-by: Łukasz Langa <[email protected]>
(cherry picked from commit 977d99d)

Co-authored-by: Rohit Nishad <[email protected]>
@bedevere-bot
Copy link

GH-27600 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Aug 4, 2021
@bedevere-bot
Copy link

GH-27601 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Aug 4, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 4, 2021
@rohitnishad613 @miss-islington
Fix 404 link to the pyporting mailing list (pythonGH-27320)
de78249 
Co-authored-by: Mariatta Wijaya <[email protected]>
Co-authored-by: Łukasz Langa <[email protected]>
(cherry picked from commit 977d99d)

Co-authored-by: Rohit Nishad <[email protected]>
@rohitnishad613 rohitnishad613 deleted the patch-1 branch August 4, 2021 19:04
miss-islington added a commit that referenced this pull request Aug 4, 2021
@miss-islington @rohitnishad613
Fix 404 link to the pyporting mailing list (GH-27320)
770be3a 
Co-authored-by: Mariatta Wijaya <[email protected]>
Co-authored-by: Łukasz Langa <[email protected]>
(cherry picked from commit 977d99d)

Co-authored-by: Rohit Nishad <[email protected]>
ambv pushed a commit that referenced this pull request Aug 4, 2021
@miss-islington @rohitnishad613
Fix 404 link to the pyporting mailing list (GH-27320) (GH-27601)
ed0d91b 
Co-authored-by: Mariatta Wijaya <[email protected]>
Co-authored-by: Łukasz Langa <[email protected]>
(cherry picked from commit 977d99d)

Co-authored-by: Rohit Nishad <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mariatta Mariatta Awaiting requested review from Mariatta

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rohitnishad613 @the-knights-who-say-ni @Mariatta @bedevere-bot @miss-islington @ambv