The Wayback Machine - https://web.archive.org/web/20221223194429/https://github.com/python/cpython/pull/27343
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-44734: Fix precision in turtle tests #27343

Merged
merged 1 commit into from Jul 26, 2021
Merged

bpo-44734: Fix precision in turtle tests #27343

merged 1 commit into from Jul 26, 2021

Conversation

loganasherjones
Copy link
Contributor

@loganasherjones loganasherjones commented Jul 25, 2021 •
edited

@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label Jul 25, 2021
FFY00
FFY00 approved these changes Jul 25, 2021
View changes
serhiy-storchaka
serhiy-storchaka reviewed Jul 25, 2021
View changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

While we are here, I suggest to inline values of vec and expected variables and remove empty lines between asserts in this method. The body of test_distance will reduce from 11 lines to 3 lines, that is more readable, and the traceback will contain more useful information.

@loganasherjones
Copy link
Contributor Author

loganasherjones commented Jul 25, 2021

Thanks for the review @serhiy-storchaka

I made the changes you requested. Let me know if there's anything else!

serhiy-storchaka
serhiy-storchaka reviewed Jul 25, 2021
View changes
Lib/test/test_turtle.py Outdated Show resolved Hide resolved
@ambv ambv merged commit 3f135c0 into python:main Jul 26, 2021
13 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Jul 26, 2021

Thanks @loganasherjones for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Jul 26, 2021

GH-27361 is a backport of this pull request to the 3.10 branch.

@bedevere-bot
Copy link

bedevere-bot commented Jul 26, 2021

GH-27362 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 26, 2021
@loganasherjones @miss-islington
bpo-44734: Fix precision in turtle tests (pythonGH-27343)
75dc99a 
(cherry picked from commit 3f135c0)

Co-authored-by: Logan Jones <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 26, 2021
@loganasherjones @miss-islington
bpo-44734: Fix precision in turtle tests (pythonGH-27343)
18a2f98 
(cherry picked from commit 3f135c0)

Co-authored-by: Logan Jones <[email protected]>
@loganasherjones loganasherjones deleted the issue-44734 branch Jul 26, 2021
ambv pushed a commit that referenced this pull request Jul 26, 2021
@miss-islington @loganasherjones
bpo-44734: Fix precision in turtle tests (GH-27343) (GH-27361)
16a174f 
(cherry picked from commit 3f135c0)

Co-authored-by: Logan Jones <[email protected]>
ambv pushed a commit that referenced this pull request Jul 26, 2021
@miss-islington @loganasherjones
bpo-44734: Fix precision in turtle tests (GH-27343) (GH-27362)
7b2185b 
(cherry picked from commit 3f135c0)

Co-authored-by: Logan Jones <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka

@FFY00 FFY00

Assignees
No one assigned
Labels
tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@loganasherjones @miss-islington @bedevere-bot @serhiy-storchaka @FFY00 @ambv @the-knights-who-say-ni