The Wayback Machine - https://web.archive.org/web/20210815015241/https://github.com/TheAlgorithms/C-Plus-Plus/pull/1306
Skip to content

/ C-Plus-Plus

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create N-bonacci.cpp #1306

Closed
wants to merge 15 commits into from
Closed

Create N-bonacci.cpp #1306

wants to merge 15 commits into from

Conversation

@neha-hasija17
Copy link
Contributor

@neha-hasija17 neha-hasija17 commented Oct 16, 2020 •
edited by gitpod-io bot

This Pull Request is for HacktoberFest 2020

Description of Change

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

@neha-hasija17
Create N-bonacci.cpp
a4b795e 
This Pull Request is for HacktoberFest 2020
@Panquesito7
Panquesito7 requested changes Oct 16, 2020
View changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Code is not up to the repository standards.
Please read them carefully and follow them.
@neha-hasija17
Update N-bonacci.cpp
0466cc5 
This Pull Request is for HacktoberFest 2020
@Panquesito7
Panquesito7 requested changes Oct 16, 2020
View changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Documentation is not up to the Doxygen guidelines.
Please read them carefully and follow them.
@neha-hasija17
Update N-bonacci.cpp
35f0ffb 
This Pull Request is for HacktoberFest 2020
@neha-hasija17 neha-hasija17 requested a review from Panquesito7 Oct 16, 2020
@Panquesito7
Panquesito7 requested changes Oct 17, 2020
View changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Documentation is not up to the Doxygen guidelines.
Please read them carefully and follow them.
math/N-bonacci.cpp Outdated Show resolved Hide resolved
math/N-bonacci.cpp Outdated
*In this code we take N and M as input where M is the number of terms
*to be printed of the N-bonacci series
*/
void N_bonacci(int n,int m){

This comment has been minimized.

Sign in to view
@Panquesito7

Panquesito7 Oct 17, 2020
Member

For how to document functions, please see #962 as a reference. 🙂

math/N-bonacci.cpp Outdated Show resolved Hide resolved
neha-hasija17 and others added 2 commits Oct 17, 2020
@neha-hasija17 @Panquesito7
Update math/N-bonacci.cpp
dd63f94 
Co-authored-by: David Leal <[email protected]>
@neha-hasija17
Update N-bonacci.cpp
921f61e 
This Pull Request is for HacktoberFest 2020
@neha-hasija17 neha-hasija17 requested a review from Panquesito7 Oct 17, 2020
@neha-hasija17
Copy link
Contributor Author

@neha-hasija17 neha-hasija17 commented Oct 17, 2020

@Panquesito7 please check it now, and let me know the error so I can resolve it asap.
@Panquesito7
Panquesito7 reviewed Oct 18, 2020
View changes
math/N-bonacci.cpp Outdated Show resolved Hide resolved
neha-hasija17 and others added 4 commits Oct 18, 2020
@neha-hasija17 @Panquesito7
Update math/N-bonacci.cpp
8a388ec 
Co-authored-by: David Leal <[email protected]>
github-actions github-actions
formatting filenames 8a388ec
2209776
github-actions github-actions
updating DIRECTORY.md
05cc612
github-actions github-actions
clang-format and clang-tidy fixes for 8a388ec
e35f026
@neha-hasija17 neha-hasija17 requested a review from Panquesito7 Oct 18, 2020
@Panquesito7
Panquesito7 reviewed Oct 18, 2020
View changes
math/n_bonacci.cpp Outdated Show resolved Hide resolved
math/n_bonacci.cpp Outdated Show resolved Hide resolved
neha-hasija17 and others added 2 commits Oct 18, 2020
@neha-hasija17 @Panquesito7
Update math/n_bonacci.cpp
be6636e 
Co-authored-by: David Leal <[email protected]>
github-actions github-actions
clang-format and clang-tidy fixes for be6636e
869de3a
@Panquesito7
Panquesito7 requested changes Oct 18, 2020
View changes
math/n_bonacci.cpp Outdated Show resolved Hide resolved
math/n_bonacci.cpp Outdated Show resolved Hide resolved
math/n_bonacci.cpp Outdated Show resolved Hide resolved
math/n_bonacci.cpp
while (t--) {
std::cout << "Enter the values of N and M : ";
std::cin >> n >> m;
N_bonacci(n, m);

This comment has been minimized.

Sign in to view
@Panquesito7

Panquesito7 Oct 18, 2020
Member

Please add self-test cases to ensure the algorithm works as expected. 🙂

This comment has been minimized.

Sign in to view
@neha-hasija17

neha-hasija17 Oct 18, 2020
Author Contributor

please help me with the same

This comment has been minimized.

Sign in to view
@Panquesito7

Panquesito7 Oct 21, 2020
Member

See the typical structure of a program as a reference.

math/n_bonacci.cpp
*In this code we take N and M as input where M is the number of terms
*to be printed of the N-bonacci series
*/
void N_bonacci(int n, int m) {

This comment has been minimized.

Sign in to view
@Panquesito7

Panquesito7 Oct 18, 2020
Member

Missing function documentation.

This comment has been minimized.

Sign in to view
@neha-hasija17

neha-hasija17 Oct 18, 2020
Author Contributor

please help me in resolving this issue

This comment has been minimized.

Sign in to view
@Panquesito7

Panquesito7 Oct 21, 2020
Member

See the typical structure of a program or #962 as a reference.

math/n_bonacci.cpp Show resolved Hide resolved
@neha-hasija17 @Panquesito7
Update math/n_bonacci.cpp
547fe78 
Co-authored-by: David Leal <[email protected]>
neha-hasija17 and others added 2 commits Oct 18, 2020
@neha-hasija17 @Panquesito7
Update math/n_bonacci.cpp
2b22387 
Co-authored-by: David Leal <[email protected]>
@neha-hasija17 @Panquesito7
Update math/n_bonacci.cpp
da9153f 
Co-authored-by: David Leal <[email protected]>
@github-actions github-actions bot force-pushed the neha-hasija17:patch-1 branch 3 times, most recently from 9744e54 to 9acb16e Oct 18, 2020
github-actions github-actions
clang-format and clang-tidy fixes for da9153f
7070e79
@github-actions github-actions bot force-pushed the neha-hasija17:patch-1 branch from 9acb16e to 7070e79 Oct 18, 2020
@neha-hasija17 neha-hasija17 requested a review from Panquesito7 Oct 21, 2020
@Panquesito7
Panquesito7 requested changes Oct 21, 2020
View changes
math/n_bonacci.cpp
while (t--) {
std::cout << "Enter the values of N and M : ";
std::cin >> n >> m;
N_bonacci(n, m);

This comment has been minimized.

Sign in to view
@Panquesito7

Panquesito7 Oct 21, 2020
Member

See the typical structure of a program as a reference.

math/n_bonacci.cpp
*In this code we take N and M as input where M is the number of terms
*to be printed of the N-bonacci series
*/
void N_bonacci(int n, int m) {

This comment has been minimized.

Sign in to view
@Panquesito7

Panquesito7 Oct 21, 2020
Member

See the typical structure of a program or #962 as a reference.

@Swastyy
Copy link
Contributor

@Swastyy Swastyy commented Jun 18, 2021

@neha-hasija17 hey! where did you find the problem statement?
Can you please tell me how can I share my solution?
(P.S. I am new to open source and need some initial help.)
@Panquesito7 Panquesito7 added this to List to Fix in Good First Issues Jun 18, 2021
@Panquesito7 Panquesito7 moved this from List to Fix to In Progress in Good First Issues Jun 18, 2021
@stale
Copy link

@stale stale bot commented Jul 19, 2021

This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
@stale stale bot added the abandoned label Jul 19, 2021
@stale
Copy link

@stale stale bot commented Jul 30, 2021

Please ping one of the maintainers once you commit the changes requested or make improvements on the code. If this is not the case and you need some help, feel free to ask for help in our Gitter channel. Thank you for your contributions!
@stale stale bot closed this Jul 30, 2021
Good First Issues automation moved this from In Progress to Completed Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Panquesito7 Panquesito7

Assignees
No one assigned
Labels
abandoned enhancement good first issue Proper Documentation Required requested changes
Projects
Good First Issues
  
Completed
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@neha-hasija17 @Swastyy @Panquesito7 @kvedala