The Wayback Machine - https://web.archive.org/web/20220221170450/https://github.com/pandas-dev/pandas/issues/42738
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPR: dropping nuisance columns in BaseWindow._apply #42738

Closed
jbrockmendel opened this issue Jul 26, 2021 · 0 comments · Fixed by #42834
Closed

DEPR: dropping nuisance columns in BaseWindow._apply #42738

jbrockmendel opened this issue Jul 26, 2021 · 0 comments · Fixed by #42834

Comments

@jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Jul 26, 2021

In BaseWindow._apply we call mgr.apply with ignore_failures=True, which causes us to silently drop columns for which the function is invalid. We have deprecated this pattern for DataFrame reductions and GroupBy reductions, should deprecate it here too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants