S3 reference style detection fixes #4273
Merged
+52
−9
Conversation
added 5 commits
Jul 8, 2021
… between host and path style reference
…nd host style s3 bucket references: 1) Any host style reference with a key did ot match, 2) {expr}*.localhost always a match, 3) {expr}*.s3.{region} did not match
…the regex match itself
…h style references
make edge.py use the existing util method instead of re-implementing the regex match itself
fix the following issues with the regex to distinguish between path and host style s3 bucket references: 1) Any host style reference with a key did ot match, 2) {expr}*.localhost always a match, 3) {expr}*.s3.{region} did not match
extend s3 unit tests to test whether URIs are correctly distinguished between host and path style reference
…stack/localstack into s3-reference-style-detection-fixes
added 3 commits
Jul 8, 2021
…stack/localstack into s3-reference-style-detection-fixes
…stack/localstack into s3-reference-style-detection-fixes
added 3 commits
Jul 9, 2021
…stack/localstack into s3-reference-style-detection-fixes # Conflicts: # tests/unit/test_s3.py
|
looks great, well done! the comments are very helpful |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Extend s3 unit tests and fix regex that distinguishes between host and path based bucket references
#4254