Fix configure.py when using bazelisk on Windows #50553
Merged
Conversation
copybara-service
bot
merged commit 311bd4d
into
tensorflow:master
13 of 17 checks passed
13 of 17 checks passed
cla/google
All necessary CLAs are signed
feedback/copybara
Google internal checks PASS for runs with create time 2021-07-14T15:23:03.363228573Z.
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Bazelisk on Windows has
bazel.cmdon the path instead ofbazel.exe, which cannot be called simply withbazelwhen usingsubprocess.runwithshell=False. Instead, we can simply use the full path obtained by thewhichcommand.