The Wayback Machine - https://web.archive.org/web/20210729041619/https://github.com/tensorflow/tensorflow/pull/50723
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing image on Android download in README.md #50723

Merged
merged 3 commits into from Jul 15, 2021

Conversation

@RinozaJiffry
Copy link
Contributor

@RinozaJiffry RinozaJiffry commented Jul 11, 2021

proposed changes

updated README file

@google-cla google-cla bot added the cla: yes label Jul 11, 2021
@gbaned gbaned self-assigned this Jul 12, 2021
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Jul 12, 2021
@gbaned gbaned requested a review from mihaimaruseac Jul 12, 2021
Copy link
Collaborator

@mihaimaruseac mihaimaruseac left a comment

What is the reasoning behind this change?

PR Queue automation moved this from Assigned Reviewer to Reviewer Requested Changes Jul 13, 2021
@RinozaJiffry
Copy link
Contributor Author

@RinozaJiffry RinozaJiffry commented Jul 14, 2021

Copy link
Collaborator

@mihaimaruseac mihaimaruseac left a comment

Rather than hotlinking, let's just remove the image. No other download link has an image.

README.md Outdated Show resolved Hide resolved
@mihaimaruseac mihaimaruseac changed the title updated README file Fix missing image on Android download in README.md Jul 14, 2021
PR Queue automation moved this from Reviewer Requested Changes to Approved by Reviewer Jul 14, 2021
@copybara-service copybara-service bot merged commit 16afe15 into tensorflow:master Jul 15, 2021
15 of 16 checks passed
15 of 16 checks passed
@tensorflow-jenkins
Intel® oneDNN -- Community CI Build oneDNN CI build failed
Details
@tensorflow-jenkins
AMD ROCm -- Community CI Build rocm CI build successful
Details
@kokoro-team
Android Demo App Internal CI build successful
Details
@kokoro-team
Linux GPU Internal CI build successful
Details
@kokoro-team
MacOS CPU Python3 Internal CI build successful
Details
@kokoro-team
TFLite Android Demo App Internal CI build successful
Details
@kokoro-team
TFLite CMake Internal CI build successful
Details
@kokoro-team
TFLite Makefile Internal CI build successful
Details
@kokoro-team
TFLite iOS Tests Internal CI build successful
Details
@kokoro-team
Ubuntu CPU Internal CI build successful
Details
@kokoro-team
Ubuntu Sanity Internal CI build successful
Details
@kokoro-team
Windows Bazel Internal CI build successful
Details
@kokoro-team
Windows Bazel GPU Internal CI build successful
Details
@google-cla
cla/google All necessary CLAs are signed
@copybara-service
feedback/copybara Google internal checks PASS for runs with create time 2021-07-15T10:41:45.683982417Z.
Details
@copybara-service
import/copybara Change imported to the internal review system
Details
PR Queue automation moved this from Approved by Reviewer to Merged Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
PR Queue
  
Merged
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants