The Wayback Machine - https://web.archive.org/web/20210810135746/https://github.com/kubernetes/kubernetes/issues/103907
Skip to content

/ kubernetes

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Operationexecutor log format problem #103907

Open
njuptlzf opened this issue Jul 26, 2021 · 7 comments · May be fixed by #103911
Open

Operationexecutor log format problem #103907

njuptlzf opened this issue Jul 26, 2021 · 7 comments · May be fixed by #103911
Assignees
@mcbenjemaa
Labels
good first issue help wanted kind/bug sig/instrumentation triage/accepted wg/structured-logging

Comments

@njuptlzf
Copy link
Contributor

@njuptlzf njuptlzf commented Jul 26, 2021

What happened:

I0726 15:05:12.072600 39595 operation_generator.go:974] UnmountDevice succeeded for volume "volume-name" %!(EXTRA string=UnmountDevice succeeded for volume "volume-name" (UniqueName: "fake-plugin/fake-device1") on node "mynodename" )

Here at the same time, simple, detail information is returned and formatting problems are caused.

What you expected to happen:

No format error. For example, only datail is returned.

How to reproduce it (as minimally and precisely as possible):

cd pkg/kubelet/volumemanager/reconciler
go test . -v

Anything else we need to know?:

Found from running pkg/kubelet/volumemanager/reconciler/reconciler_test.go

Environment:

  • Kubernetes version (use kubectl version):
  • Cloud provider or hardware configuration:
  • OS (e.g: cat /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Network plugin and version (if this is a network-related bug):
  • Others:

/good-first-issue
@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Jul 26, 2021

@njuptlzf:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

What happened:

I0726 15:05:12.072600 39595 operation_generator.go:974] UnmountDevice succeeded for volume "volume-name" %!(EXTRA string=UnmountDevice succeeded for volume "volume-name" (UniqueName: "fake-plugin/fake-device1") on node "mynodename" )

Here at the same time, simple, detail information is returned and formatting problems are caused.

What you expected to happen:

No format error. For example, only datail is returned.

How to reproduce it (as minimally and precisely as possible):

cd pkg/kubelet/volumemanager/reconciler
go test . -v

Anything else we need to know?:

Found from running pkg/kubelet/volumemanager/reconciler/reconciler_test.go

Environment:

  • Kubernetes version (use kubectl version):
  • Cloud provider or hardware configuration:
  • OS (e.g: cat /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Network plugin and version (if this is a network-related bug):
  • Others:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@yuzhiquan
Copy link
Member

@yuzhiquan yuzhiquan commented Jul 26, 2021

/triage accepted
/sig instrumentation
/wg structured-logging
@yuzhiquan
Copy link
Member

@yuzhiquan yuzhiquan commented Jul 26, 2021

Seems like caused by https://github.com/kubernetes/kubernetes/blob/master/pkg/volume/util/operationexecutor/operation_generator.go#L974, this line still not in structured logging, we need to handle these messages.
@njuptlzf
Copy link
Contributor Author

@njuptlzf njuptlzf commented Jul 26, 2021

I don’t know if this package will be accepted for structured log migration.
It seems that only kubelet is required now.
@mcbenjemaa
Copy link
Member

@mcbenjemaa mcbenjemaa commented Jul 26, 2021

/assign
@ping035627
Copy link
Contributor

@ping035627 ping035627 commented Jul 26, 2021

I think it‘s only kubelet required too.
@yuswift yuswift linked a pull request that will close this issue Jul 26, 2021
Open
@yuswift
Copy link

@yuswift yuswift commented Jul 26, 2021 •
edited

@mcbenjemaa Hi, sorry about that I didn't realize that you assigned yourself to this issue. Hope #103911 is helpful for this issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcbenjemaa mcbenjemaa

Labels
good first issue help wanted kind/bug sig/instrumentation triage/accepted wg/structured-logging
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Fix pkg/volume/util/operationexecutor/operation_generator.go log format problem
6 participants
@yuzhiquan @mcbenjemaa @ping035627 @k8s-ci-robot @yuswift @njuptlzf