The Wayback Machine - https://web.archive.org/web/20210306015002/https://github.com/arduino/arduino-cli/pull/1027
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored config to not use viper singleton instance #1027

Merged
merged 6 commits into from Oct 14, 2020

Conversation

@silvanocerza
Copy link
Contributor

@silvanocerza silvanocerza commented Oct 12, 2020

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce?
    Refactors how the configs are initialized and fixes config init.
  • What is the current behavior?
    Configs are managed using the viper package singleton, config init command reads from existing settings when initializing a new config file.
  • What is the new behavior?
    Configs are not managed anymore with the viper package singleton but using a global variable internal to the configuration package of the arduino-cli.
    The config init command now initializes new config files using the default values without reading from existing files.
  • Does this PR introduce a breaking change?
    Yes.
  • Other information:
    None.

See how to contribute

@silvanocerza silvanocerza force-pushed the scerza/config-refactoring branch from fbc09e0 to cd1d472 Oct 12, 2020
Copy link

@ubidefeo ubidefeo left a comment

Tested and it finally works

Copy link
Member

@cmaglie cmaglie left a comment

I've added some more commits, so I approve all the rest :-)
@silvanocerza if you are ok with my changes, IMHO this is ready to merge.

@silvanocerza silvanocerza merged commit 9f49ea3 into master Oct 14, 2020
15 checks passed
15 checks passed
Lints Python code Lints Python code
Details
verify-links verify-links
Details
verify-links verify-links
Details
test-matrix (ubuntu-latest) test-matrix (ubuntu-latest)
Details
test-matrix (ubuntu-latest) test-matrix (ubuntu-latest)
Details
validate validate
Details
validate validate
Details
test-matrix (windows-latest) test-matrix (windows-latest)
Details
test-matrix (windows-latest) test-matrix (windows-latest)
Details
test-matrix (macOS-latest) test-matrix (macOS-latest)
Details
test-matrix (macOS-latest) test-matrix (macOS-latest)
Details
create-test-artifacts
Details
create-test-artifacts
Details
codecov/project 38.01% (target 30.00%)
Details
license/cla Contributor License Agreement is signed.
Details
@silvanocerza silvanocerza deleted the scerza/config-refactoring branch Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants