The Wayback Machine - https://web.archive.org/web/20210306015045/https://github.com/arduino/arduino-cli/pull/1130
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance error messages if config paths are not valid #1130

Merged
merged 1 commit into from Jan 13, 2021

Conversation

@silvanocerza
Copy link
Contributor

@silvanocerza silvanocerza commented Jan 12, 2021

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • What kind of change does this PR introduce?

Enhances error messages.

  • What is the current behavior?

If there are invalid paths for certain settings in the config file multiple errors are returned but are not clear enough, also certain commands still keep going forward.

  • What is the new behavior?

Full invalid paths in the config file are now printed in full and only one error is shown, execution also stops for all commands if an error is returned.

No breaking change.

  • Other information:

Solves #1114.

See how to contribute

@silvanocerza silvanocerza requested review from ubidefeo, per1234 and rsora Jan 12, 2021
@silvanocerza silvanocerza self-assigned this Jan 12, 2021
@silvanocerza silvanocerza requested a review from cmaglie Jan 12, 2021
@silvanocerza
Copy link
Contributor Author

@silvanocerza silvanocerza commented Jan 12, 2021

PyPi is having issues so CI is failing since it can't install depencencies necessary for testing. I'll restart it as soon as the issue on PyPi is solved.

cli/cli.go Outdated Show resolved Hide resolved
@silvanocerza silvanocerza force-pushed the scerza/enhance-error-message branch from 246411b to 32dc14f Jan 13, 2021
@silvanocerza silvanocerza merged commit 50eef88 into master Jan 13, 2021
14 checks passed
14 checks passed
verify-links
Details
verify-links
Details
test-matrix (ubuntu-latest)
Details
test-matrix (ubuntu-latest)
Details
validate
Details
validate
Details
test-matrix (windows-latest)
Details
test-matrix (windows-latest)
Details
test-matrix (macOS-latest)
Details
test-matrix (macOS-latest)
Details
create-test-artifacts
Details
create-test-artifacts
Details
codecov/project 37.62% (target 30.00%)
Details
license/cla Contributor License Agreement is signed.
Details
@silvanocerza silvanocerza deleted the scerza/enhance-error-message branch Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants