The Wayback Machine - https://web.archive.org/web/20210306015453/https://github.com/arduino/arduino-cli/pull/1200
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skip changelog] Improve wording of docs introduction #1200

Merged
merged 1 commit into from Feb 26, 2021

Conversation

@per1234
Copy link
Contributor

@per1234 per1234 commented Feb 26, 2021

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • What kind of change does this PR introduce?

docs update

  • What is the current behavior?

The introductory sentence of the documentation homepage is the first thing the user may see when discovering Arduino
CLI. For this reason, it's important for it to quickly and clearly convey what Arduino CLI is. It's possible the current wording could be improved to do a better job of this.

  • What is the new behavior?

The wording of the sentence is improved via the following changes:

  • Use more understandable terms
  • Rearrange features list in the order of typical usage (install dependencies, compile, upload)
  • Does this PR introduce a breaking change, and is
    titled accordingly?

Does this PR introduce a breaking change

No

is titled accordingly
Yes

  • Other information:

I have changed the term "discovery" to "board detection". I feel that the meaning of "discovery" in this context is not widely known. The only uses of "discovery" in the documentation refer to library discovery, which is not the meaning of "discovery" in this sentence.


Credit for the suggested changes goes to @ubidefeo

@per1234 per1234 requested a review from ubidefeo Feb 26, 2021
The introductory sentence of the documentation homepage is the first thing the user may see when discovering Arduino
CLI. For this reason, it's important for it to quickly and clearly convey what Arduino CLI is. Toward that goal, the
following changes are made:

- Use more understandable terms
- Rearrange features list in the order of typical usage (install dependencies, compile, upload)
@per1234 per1234 force-pushed the per1234:improve-title-sentence branch from cb976f7 to 3bb1979 Feb 26, 2021
Copy link

@ubidefeo ubidefeo left a comment

LGTM

@per1234 per1234 merged commit bf364db into arduino:master Feb 26, 2021
8 checks passed
8 checks passed
verify-links
Details
verify-formatting
Details
test-matrix (ubuntu-20.04)
Details
validate
Details
test-matrix (windows-latest)
Details
test-matrix (macOS-latest)
Details
create-test-artifacts
Details
license/cla Contributor License Agreement is signed.
Details
@per1234 per1234 deleted the per1234:improve-title-sentence branch Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants