The Wayback Machine - https://web.archive.org/web/20210807164915/https://github.com/go-gitea/gitea/pull/13458

go-gitea / gitea

Sponsor

Sponsor go-gitea/gitea
Notifications
Star 25.7k
Fork 3.2k

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tooltips and issue dependency styles #13458

Merged

lafriks merged 1 commit into go-gitea:master from silverwind:tooltips

Nov 10, 2020

Member

silverwind commented Nov 7, 2020 •

edited

Convert all CSS tooltips to JS-based ones, fixing overflow issues
Restyle issue dependencies/dependants
Move popup styles to base style
CSS Helper tweaks
Unify pseudo element selectors and lint for it

Fixes: #13400

silverwind force-pushed the silverwind:tooltips branch 5 times, most recently from e2e29ca to 3a1a533

Member

lafriks commented Nov 7, 2020

Please resolve conflicts

GiteaBot added the lgtm/need 2 label

lafriks modified the milestone: Ui

lafriks added the kind/ui label

lafriks added this to the 1.14.0 milestone

lafriks added the skip-changelog label

silverwind force-pushed the silverwind:tooltips branch from 3a1a533 to e3fde8f

Member Author

silverwind commented Nov 8, 2020

Rebased and screenshots updated.

lafriks reviewed

web_src/less/_repository.less Outdated Show resolved Hide resolved

silverwind force-pushed the silverwind:tooltips branch from 1f51bc9 to fbef8c2

Member Author

silverwind commented Nov 8, 2020

@lafriks converted to double-colon syntax and changed linting for it.

zeripath reviewed

templates/admin/user/edit.tmpl Outdated Show resolved Hide resolved

zeripath approved these changes

GiteaBot added lgtm/need 1 and removed lgtm/need 2 labels

Member

6543 commented Nov 9, 2020

@silverwind it's conflicting again

Member

lafriks commented Nov 10, 2020

I would say that column count should not be changed because it could have undesirable effect. Generally I think single : is better because it does not create additional pseido elements in DOM but if we remove them it could effect spacing etc especially where we have content: ' ' in css. So imho for now this rune should be disabled and column usage : or :: should be reviewed in other PR

Member Author

silverwind commented Nov 10, 2020 •

edited

I don't think there is any practical difference between ::before vs :before. I've been using them interchangeable for a long time and I think it's purely a stylistic thing. One could argue : saves a few bytes and I generally prefer the single colon syntax because I don't want to think whether something is a pseudo element or a pseudo selector. Yes, I can remove these changes for now.

Member

lafriks commented Nov 10, 2020

On second thought I don't mind having :: in this PR, so leave at it is now


          Fix tooltips and issue dependency styles

- Convert all tooltips to JS-based ones, fixing overflow issues
- Restyle issue dependencies/dependants
- Move popup styles to base style
- CSS Helper tweaks
- Unify pseudo element selectors and lint for it

Fixes: #13400

silverwind force-pushed the silverwind:tooltips branch from b632faa to 5129268

Member Author

silverwind commented Nov 10, 2020

Rebased and squashed.

lafriks approved these changes

GiteaBot removed the lgtm/need 1 label

GiteaBot added the lgtm/done label

lafriks merged commit 21d4963 into go-gitea:master

2 checks passed

2 checks passed

approvals/lgtm this commit looks good

continuous-integration/drone/pr Build is passing

Details

silverwind deleted the silverwind:tooltips branch

silverwind added a commit to silverwind/gitea that referenced this pull request


          Fix issue dependency spacing and hover

147573d

Fixes: go-gitea#13545
Regressed by: go-gitea#13458

silverwind mentioned this pull request

Fix issue label spacing and hover #13553

Merged

silverwind added a commit to silverwind/gitea that referenced this pull request


          Fix issue label spacing and hover

Fixes: go-gitea#13545
Regressed by: go-gitea#13458

techknowlogick pushed a commit that referenced this pull request


          Fix issue label spacing and hover (#13553)

5c76c5c

Fixes: #13545
Regressed by: #13458

go-gitea locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.