The Wayback Machine - https://web.archive.org/web/20210807165126/https://github.com/go-gitea/gitea/pull/15739
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use binary version of revive linter #15739

Merged
merged 4 commits into from May 9, 2021
Merged

Use binary version of revive linter #15739

merged 4 commits into from May 9, 2021

Conversation

@silverwind
Copy link
Member

@silverwind silverwind commented May 5, 2021

Use the common go get method to install and run the revive linter, removing the useless build/lint.go and related vendor libraries.

Use the common `go get` method to install and run the revive linter,
removing the useless build/lint.go and related vendor libraries.
@silverwind silverwind force-pushed the silverwind:revive branch from 33504b5 to bc2d067 May 5, 2021
@silverwind silverwind changed the title Replace revive linter with binary call Use binary version of revive linter May 5, 2021
@silverwind
Copy link
Member Author

@silverwind silverwind commented May 5, 2021

This basically undoes #10942. I think it's bad practice to vendor such tools completely because one can easily forget to update them and the method was kind of only used for one of many tools in use.

@silverwind silverwind added this to the 1.15.0 milestone May 6, 2021
@lunny
lunny approved these changes May 7, 2021
@KN4CK3R
KN4CK3R approved these changes May 8, 2021
@6543
6543 approved these changes May 9, 2021
@6543 6543 merged commit c3802dc into go-gitea:main May 9, 2021
2 checks passed
2 checks passed
approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details
@silverwind silverwind deleted the silverwind:revive branch May 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants