The Wayback Machine - https://web.archive.org/web/20210807165157/https://github.com/go-gitea/gitea/pull/15860
Skip to content

/ gitea

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add jest rootDir and test-frontend dependency #15860

Merged
merged 3 commits into from May 14, 2021
Merged

Add jest rootDir and test-frontend dependency #15860

merged 3 commits into from May 14, 2021

Conversation

@silverwind
Copy link
Member

@silverwind silverwind commented May 13, 2021 •
edited

  • Define jest rootDir to limit where it looks for test files, speeding it up a bit
  • Add missing dependency on test-frontend target so it can be ran from a clean checkout
@silverwind
Add jest rootDir and test-frontend dependency
a3ba49e 
- Define jest rootDir to limit where it looks for test files
- Add missing dependency on test-frontend target so it can be ran from a
  clean checkout
@zeripath
zeripath approved these changes May 13, 2021
View changes
@zeripath zeripath added this to the 1.15.0 milestone May 13, 2021
@zeripath
Copy link
Contributor

@zeripath zeripath commented May 13, 2021

Did this make it in to 1.14? If so as it will speed up build it may be worth backporting.
@silverwind
Copy link
Member Author

@silverwind silverwind commented May 13, 2021

No, test-frontend is 1.15 only. The speedup is very minor, only like 2 seconds on CI, bit still noticeable.
@noerw
noerw approved these changes May 14, 2021
View changes
@techknowlogick
Merge branch 'main' into jesttweak
38cf0d9
@techknowlogick
Merge branch 'main' into jesttweak
b5858cc
@zeripath
Copy link
Contributor

@zeripath zeripath commented May 14, 2021

Make lgtm work
@zeripath zeripath merged commit 05fb1f6 into go-gitea:main May 14, 2021
2 checks passed
2 checks passed
approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details
@silverwind silverwind deleted the silverwind:jesttweak branch May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeripath zeripath

@noerw noerw

Assignees
No one assigned
Labels
kind/testing lgtm/done skip-changelog
Milestone
1.15.0
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@silverwind @zeripath @noerw @GiteaBot @techknowlogick