Replace clipboard.js with async clipboard api #15899
Merged
Conversation
Use async clipboard api [1] over this dependency, saving around 10kB bundle size before minify while delivering the same functionality. The issue comment button works but does not have a popup indication. We could add some toast-style notifications in the future to fix that but I think it's out of scope of this PR. [1] https://developer.mozilla.org/en-US/docs/Web/API/Clipboard/writeText
|
make lgtm work |
zeripath
merged commit 3720503
into
go-gitea:main
2 checks passed
2 checks passed
approvals/lgtm
this commit looks good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Use async clipboard api over this dependency, saving around 10kB bundle size before minify while delivering the same functionality.
The issue comment button works but does not have a popup indication (didn't have one before either). We could add some toast-style notifications in the future to fix that but I think it's out of scope of this PR.