The Wayback Machine - https://web.archive.org/web/20210807164406/https://github.com/go-gitea/gitea/pull/16421
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change docker tag logic #16421

Merged
merged 5 commits into from Jul 14, 2021
Merged

Change docker tag logic #16421

merged 5 commits into from Jul 14, 2021

Conversation

@techknowlogick
Copy link
Member

@techknowlogick techknowlogick commented Jul 13, 2021

This PR changes the image tagged as :latest on docker hub to represent the :latest released version of Gitea.

  • :latest will now be mapped to latest tag on the 1.15 branch.
  • :dev will represent the latest build from the main branch.

Replace: #15889
Fixes #15622

thanks to @pat-s for the initial work on this PR :)

⚠️ BREAKING ⚠️

Previously the :latest docker tag would map to the latest build from main. Users who wish to use the absolute latest version of Gitea should migrate to use :dev and we would ask that at least some users do consider using the :dev tag if possible.

@techknowlogick techknowlogick changed the title Change docker logic Change docker tag logic Jul 13, 2021
@codecov-commenter

This comment was marked as off-topic.

@techknowlogick techknowlogick mentioned this pull request Jul 13, 2021
1 of 3 tasks
@techknowlogick techknowlogick added this to the 1.15.0 milestone Jul 13, 2021
@techknowlogick techknowlogick requested review from sapk and pat-s Jul 13, 2021
Copy link
Contributor

@kdumontnu kdumontnu left a comment

This requires an update in gitea/docs/content/doc/installation/with-docker* docs, right?

docker/manifest.rootless.tmpl Outdated Show resolved Hide resolved
docker/manifest.rootless.tmpl Outdated Show resolved Hide resolved
.drone.yml Show resolved Hide resolved
@techknowlogick
Copy link
Member Author

@techknowlogick techknowlogick commented Jul 14, 2021

@kdumontnu docs have been updated :)

Copy link
Contributor

@kdumontnu kdumontnu left a comment

👍 (fair warning: I'm not a docker expert, but it resolves the initial issues I saw)

@sapk
sapk approved these changes Jul 14, 2021
@zeripath zeripath merged commit e180456 into go-gitea:main Jul 14, 2021
2 checks passed
2 checks passed
approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details
@kdumontnu
Copy link
Contributor

@kdumontnu kdumontnu commented Jul 14, 2021

Wait, do the manifest/docker plugins have the logic to not tag latest on 1.14.5 if there is already a 1.15.0 release? I'm assuming we don't want previous minor releases to overtake the latest major release.

@lafriks
Copy link
Member

@lafriks lafriks commented Jul 14, 2021

No it does not have

@techknowlogick techknowlogick deleted the techknowlogick:docker-changes branch Jul 14, 2021
@pat-s
Copy link
Member

@pat-s pat-s commented Jul 14, 2021

That was quick in the end 😅 👍

@sapk
Copy link
Member

@sapk sapk commented Jul 14, 2021

@kdumontnu it is a problem already existing previously and we always have to re-build a latest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

9 participants