The Wayback Machine - https://web.archive.org/web/20210801040557/https://github.com/dfinke/ImportExcel/pull/1057
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added compatibility for PS5 and lower #1057

Closed
wants to merge 1 commit into from
Closed

Conversation

@DEberhardt
Copy link

@DEberhardt DEberhardt commented Jul 30, 2021

Don't know whether the rest of the code would work, but as $IsWindows is not returning TRUE in PS v5, I thought to add $PSVersionTable.PSEdition -eq "Desktop"

fixes #1056

Don't know whether the rest of the code would work, but as $IsWindows is not returning TRUE in PS v5, I thought to add $PSVersionTable.PSEdition -eq "Desktop"
@dfinke
Copy link
Owner

@dfinke dfinke commented Jul 30, 2021

Thank you! Looks like it returns $false on Linux. Going to refactor this a bit so I can add a pester test for checking where/what PS is running on

dfinke added a commit that referenced this pull request Jul 30, 2021
@dfinke
Copy link
Owner

@dfinke dfinke commented Jul 30, 2021

Thank you for PR, went with a different set of checks.

@dfinke dfinke closed this Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants