fix(router): error if module is destroyed before location is initialized #42560
Conversation
| if (this.destroyed) { | ||
| return Promise.resolve(true); | ||
| } | ||
|
|
crisbeto
Jun 12, 2021
Author
Member
Another way of solving this would be to pull the injector.get calls outside of the callback. I decided against it, because I wasn't sure if the Router and RouterConfiguration would be available earlier in the lifecycle.
Another way of solving this would be to pull the injector.get calls outside of the callback. I decided against it, because I wasn't sure if the Router and RouterConfiguration would be available earlier in the lifecycle.
This is something I ran into while working on a fix for the `TestBed` module teardown behavior for #18831. In the `RouterInitializer.appInitializer` we have a callback to the `LOCATION_INITIALIZED` which has to do some DI lookups. The problem is that if the module is destroyed before the location promise resolves, the `Injector.get` calls will fail. This is unlikely to happen in a real app, but it'll show up in unit tests once the test module teardown behavior is fixed.
dylhunn
added a commit
that referenced
this pull request
Jun 17, 2021
…zed (#42560) This is something I ran into while working on a fix for the `TestBed` module teardown behavior for #18831. In the `RouterInitializer.appInitializer` we have a callback to the `LOCATION_INITIALIZED` which has to do some DI lookups. The problem is that if the module is destroyed before the location promise resolves, the `Injector.get` calls will fail. This is unlikely to happen in a real app, but it'll show up in unit tests once the test module teardown behavior is fixed. PR Close #42560
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This is something I ran into while working on a fix for the
TestBedmodule teardown behavior for #18831. In theRouterInitializer.appInitializerwe have a callback to theLOCATION_INITIALIZEDwhich has to do some DI lookups. The problem is that if the module is destroyed before the location promise resolves, theInjector.getcalls will fail. This is unlikely to happen in a real app, but it'll show up in unit tests once the test module teardown behavior is fixed.