The Wayback Machine - https://web.archive.org/web/20211128215142/https://github.com/electron/electron/pull/30330
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use contentAspectRatio in setAspectRatio() on macOS #30330

Merged
merged 1 commit into from Aug 2, 2021
Merged

fix: use contentAspectRatio in setAspectRatio() on macOS #30330

merged 1 commit into from Aug 2, 2021

Conversation

@trop
Copy link
Contributor

@trop trop bot commented Jul 29, 2021

Backport of #30305

See that PR for details.

Notes: Fixes an issue where a specified aspect ratio could become incorrect when maximizing a window on macOS.
@trop trop bot requested a review from codebytere Jul 29, 2021
@trop trop bot mentioned this pull request Jul 29, 2021
Merged
3 tasks
zcbenz
zcbenz approved these changes Aug 2, 2021
View changes
@zcbenz zcbenz merged commit 6627beb into 13-x-y Aug 2, 2021
12 of 15 checks passed
Loading
@zcbenz zcbenz deleted the trop/13-x-y-bp-fix-use-contentaspectratio-in-setaspectratio-on-macos-1627594060616 branch Aug 2, 2021
@release-clerk
Copy link

@release-clerk release-clerk bot commented Aug 2, 2021

Release Notes Persisted

Fixes an issue where a specified aspect ratio could become incorrect when maximizing a window on macOS.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz

@MarshallOfSound MarshallOfSound

@codebytere codebytere

Assignees
No one assigned
Labels
13-x-y backport semver/patch
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@zcbenz @MarshallOfSound @codebytere