The Wayback Machine - https://web.archive.org/web/20221101114855/https://github.com/electron/electron/pull/30359
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: update build images to update npm and node #30359

Merged
merged 1 commit into from Aug 2, 2021
Merged

build: update build images to update npm and node #30359

merged 1 commit into from Aug 2, 2021

Conversation

MarshallOfSound
Copy link
Member

@MarshallOfSound MarshallOfSound commented Jul 30, 2021

Pulls in electron/build-images#11

Notes: none

@MarshallOfSound MarshallOfSound added semver/none target/11-x-y target/12-x-y PR should also be added to the "12-x-y" branch. target/13-x-y PR should also be added to the "13-x-y" branch. target/14-x-y PR should also be added to the "14-x-y" branch. target/15-x-y PR should also be added to the "15-x-y" branch. and removed target/11-x-y target/12-x-y PR should also be added to the "12-x-y" branch. target/13-x-y PR should also be added to the "13-x-y" branch. target/14-x-y PR should also be added to the "14-x-y" branch. labels Jul 30, 2021
nornagon
nornagon approved these changes Jul 30, 2021
View changes
Copy link
Member

@nornagon nornagon left a comment

seems legit

zcbenz
zcbenz approved these changes Aug 2, 2021
View changes
@zcbenz zcbenz merged commit 9693fb9 into main Aug 2, 2021
20 checks passed
@zcbenz zcbenz deleted the update-build-images branch Aug 2, 2021
@release-clerk
Copy link

release-clerk bot commented Aug 2, 2021

No Release Notes

@trop trop bot mentioned this pull request Aug 2, 2021
Merged
@trop
Copy link
Contributor

trop bot commented Aug 2, 2021

I have automatically backported this PR to "15-x-y", please check out #30364

@trop trop bot added in-flight/15-x-y merged/15-x-y PR was merged to the "15-x-y" branch. and removed target/15-x-y PR should also be added to the "15-x-y" branch. in-flight/15-x-y labels Aug 2, 2021
BlackHole1 pushed a commit to BlackHole1/electron that referenced this pull request Aug 30, 2021
@MarshallOfSound @BlackHole1
build: update build images to update npm and node (electron#30359)
6291464
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon

@zcbenz zcbenz

Assignees
No one assigned
Labels
merged/15-x-y PR was merged to the "15-x-y" branch. semver/none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MarshallOfSound @nornagon @zcbenz