The Wayback Machine - https://web.archive.org/web/20210202124421/https://github.com/go-sql-driver/mysql/pull/612
Skip to content

/ mysql

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add atomic wrappers for bool and error #612

Merged
merged 3 commits into from Jun 10, 2017
Merged

Add atomic wrappers for bool and error #612

merged 3 commits into from Jun 10, 2017

Conversation

@julienschmidt
Copy link
Member

@julienschmidt julienschmidt commented Jun 9, 2017 •
edited

Improves #608 by using re-usable wrappers for atomic booleans and also replaces mc.closedErr guarded by a lock with an atomic error field.

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary
  • Added myself / the copyright holder to the AUTHORS file
@julienschmidt
Add atomic wrappers for bool and error
Loading status checks…
1d79804 
Improves #608
@julienschmidt julienschmidt added this to the v1.4 milestone Jun 9, 2017
@julienschmidt
Drop Go 1.2 and Go 1.3 support
Loading status checks…
66a7d3e
@julienschmidt
"test" noCopy.Lock()
Loading status checks…
f050628
@julienschmidt julienschmidt mentioned this pull request Jun 9, 2017
Merged
5 of 5 tasks complete
@methane
methane approved these changes Jun 10, 2017
View changes
Copy link
Member

@methane methane left a comment

LGTM
@julienschmidt julienschmidt merged commit 72e0ac3 into master Jun 10, 2017
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.1%) to 75.445%
Details
@julienschmidt julienschmidt deleted the atomic branch Jun 10, 2017
@jsha jsha mentioned this pull request Nov 14, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@methane methane

Assignees
No one assigned
Labels
performance
Projects
None yet
Milestone
v1.4.0
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@julienschmidt @methane