The Wayback Machine - https://web.archive.org/web/20201121042857/https://github.com/protobufjs/protobuf.js/issues/1106
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eslint-disable comment in generated source should include default-case #1106

Open
mlhales opened this issue Aug 22, 2018 · 1 comment
Open

eslint-disable comment in generated source should include default-case #1106

mlhales opened this issue Aug 22, 2018 · 1 comment

Comments

@mlhales
Copy link

@mlhales mlhales commented Aug 22, 2018

protobuf.js version: 6.8.8

For enumerations defined in proto3, the switch statement generated by pbjs triggers the eslint warning default-case since there is no default case. This should be added to the list of eslint-disable rules in the header comment of the generated source file.

@UniverseHan
Copy link

@UniverseHan UniverseHan commented Sep 14, 2020

Which one is better

  • disable warning or
  • add default case which throws error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.