The Wayback Machine - https://web.archive.org/web/20221223134403/https://github.com/python/cpython/pull/19043
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39991: uuid._netstat_getnode() ignores IPv6 addresses #19043

Merged
merged 1 commit into from Mar 17, 2020

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Mar 17, 2020

uuid.getnode() now skips IPv6 addresses with the same string length
than a MAC address (17 characters): only use MAC addresses.

https://bugs.python.org/issue39991

uuid.getnode() now skips IPv6 addresses with the same string length
than a MAC address (17 characters): only use MAC addresses.
@vstinner
Copy link
Member Author

vstinner commented Mar 17, 2020

I tested manually: this PR fix my issue on FreeBSD https://bugs.python.org/issue39991

@vstinner vstinner merged commit eb886db into python:master Mar 17, 2020
@vstinner vstinner deleted the uuid_ipv6 branch Mar 17, 2020
@miss-islington
Copy link
Contributor

miss-islington commented Mar 17, 2020

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒🤖

@miss-islington
Copy link
Contributor

miss-islington commented Mar 17, 2020

Sorry, @vstinner, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker eb886db1e99a15f15a2342aa496197a5f88fa9c8 3.8

@vstinner
Copy link
Member Author

vstinner commented Mar 17, 2020

Oh, Python 3.8 doesn't seem to be affected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants