The Wayback Machine - https://web.archive.org/web/20210802173948/https://github.com/labstack/echo/pull/1792
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve code quality #1792

Merged
merged 3 commits into from Feb 26, 2021
Merged

improve code quality #1792

merged 3 commits into from Feb 26, 2021

Conversation

@withshubh
Copy link
Contributor

@withshubh withshubh commented Feb 25, 2021

Description

This PR fixes a few issues that improve the code quality.

Summary of changes

  • Merge variable declaration with assignment
  • Fix unnecessary typecasting on bytes.Buffer
  • Remove unnecessary wrapping of function call
@codecov
Copy link

@codecov codecov bot commented Feb 25, 2021

Codecov Report

Merging #1792 (f25e77f) into master (b0f56ea) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1792      +/-   ##
==========================================
- Coverage   89.75%   89.73%   -0.03%     
==========================================
  Files          32       32              
  Lines        2675     2669       -6     
==========================================
- Hits         2401     2395       -6     
  Misses        175      175              
  Partials       99       99              
Impacted Files Coverage Δ
middleware/rate_limiter.go 100.00% <ø> (ø)
binder.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0f56ea...f25e77f. Read the comment docs.

@aldas aldas merged commit 6a666ac into labstack:master Feb 26, 2021
15 checks passed
15 checks passed
@github-actions
ubuntu-latest @ Go 1.12
Details
@github-actions
ubuntu-latest @ Go 1.13
Details
@github-actions
ubuntu-latest @ Go 1.14
Details
@github-actions
ubuntu-latest @ Go 1.15
Details
@github-actions
macos-latest @ Go 1.12
Details
@github-actions
macos-latest @ Go 1.13
Details
@github-actions
macos-latest @ Go 1.14
Details
@github-actions
macos-latest @ Go 1.15
Details
@github-actions
windows-latest @ Go 1.12
Details
@github-actions
windows-latest @ Go 1.13
Details
@github-actions
windows-latest @ Go 1.14
Details
@github-actions
windows-latest @ Go 1.15
Details
@github-actions
Benchmark comparison ubuntu-latest @ Go 1.15
Details
@codecov
codecov/patch 100.00% of diff hit (target 89.75%)
Details
@codecov
codecov/project 89.73% (-0.03%) compared to b0f56ea
Details
@aldas
Copy link
Contributor

@aldas aldas commented Feb 26, 2021

Thanks

@withshubh
Copy link
Contributor Author

@withshubh withshubh commented Feb 26, 2021

@aldas
I would like to share that I ran DeepSource analyzer on my fork of this repository to detect these issues. Have a look at the issues caught in this repository by DeepSource here.

DeepSource is a code review automation tool that detects code quality issues and helps you to automatically fix some of them. You can use DeepSource to track test coverage, Detect problems in Dockerfiles, etc. in addition to detecting issues in code.

Can I submit an issue as a feature request for DeepSource integration or PR(consisting of a configuration file only)?
You can merge the configuration file to activate the analysis to continuously analyze the repo and fix code quality issues.

This was referenced Mar 8, 2021
@withshubh
Copy link
Contributor Author

@withshubh withshubh commented Mar 30, 2021

Hey @aldas any update on my last comment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants