The Wayback Machine - https://web.archive.org/web/20210715004756/https://github.com/nuxt/nuxt.js/pull/6197
Skip to content

/ nuxt.js

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(babel-preset-app): remove babel-plugin-dynamic-import-node #6197

Merged
merged 1 commit into from Aug 8, 2019
Merged

refactor(babel-preset-app): remove babel-plugin-dynamic-import-node #6197

merged 1 commit into from Aug 8, 2019

Conversation

@clarkdo
Copy link
Member

@clarkdo clarkdo commented Aug 7, 2019

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

dynamic-import has been added into preset-env since https://github.com/babel/babel/releases/tag/v7.5.0, so we can remove from code.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.
@clarkdo
refactor: remove babel-plugin-dynamic-import-node
55097aa
@manniL
manniL approved these changes Aug 7, 2019
View changes
@pi0 pi0 changed the title refactor: remove babel-plugin-dynamic-import-node refactor(babel-preset-app): remove babel-plugin-dynamic-import-node Aug 8, 2019
@pi0 pi0 merged commit c436839 into nuxt:dev Aug 8, 2019
9 checks passed
9 checks passed
@semantic-pull-requests
Semantic Pull Request ready to be squashed
Details
[ci.azure] nuxt.js #20190807.12 succeeded
Details
ci/circleci: audit Your tests passed on CircleCI!
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: lint-app Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test-e2e Your tests passed on CircleCI!
Details
ci/circleci: test-unit Your tests passed on CircleCI!
Details
@pi0 pi0 mentioned this pull request Aug 10, 2019
Merged
pi0 added a commit that referenced this pull request Aug 20, 2019
@clarkdo @pi0
refactor(babel-preset-app): remove babel-plugin-dynamic-import-node (…
a07a4fb 
…#6197)
@clarkdo clarkdo deleted the clarkdo:remove-dynamic-import branch Sep 7, 2019
@snyk-bot snyk-bot mentioned this pull request Nov 12, 2019
Open
@snyk-bot snyk-bot mentioned this pull request Nov 25, 2019
Open
This was referenced Apr 15, 2020
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manniL manniL

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@clarkdo @manniL @pi0