The Wayback Machine - https://web.archive.org/web/20210807164447/https://github.com/go-gitea/gitea/pull/16544
Skip to content

/ gitea

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add microsoft oauth2 providers #16544

Merged
merged 9 commits into from Aug 6, 2021
Merged

Add microsoft oauth2 providers #16544

merged 9 commits into from Aug 6, 2021
+2,132 −260

Conversation

@zeripath
Copy link
Contributor

@zeripath zeripath commented Jul 25, 2021 •
edited

Users commonly want to be able to use their AzureAD or MicrosoftOnline accounts with Gitea.

This PR adds the goth.Providers for Azure and microsoft online.

Fix #6866
Fix #12073
zeripath added 2 commits Jul 24, 2021
@zeripath
Clean up oauth2 providers
d094cea 
Signed-off-by: Andrew Thornton <[email protected]>
@zeripath
Add AzureAD, AzureADv2, MicrosoftOnline OAuth2 providers
a1058ae 
Signed-off-by: Andrew Thornton <[email protected]>
@zeripath zeripath force-pushed the zeripath:add-microsoft-oauth2-providers branch from dd7497e to a1058ae Jul 25, 2021
@codecov-commenter
Copy link

@codecov-commenter codecov-commenter commented Jul 25, 2021 •
edited

Codecov Report

Merging #16544 (f629cd2) into main (6e6f23b) will increase coverage by 0.02%.
The diff coverage is 45.10%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #16544      +/-   ##
==========================================
+ Coverage   45.37%   45.39%   +0.02%     
==========================================
  Files         750      756       +6     
  Lines       85115    85247     +132     
==========================================
+ Hits        38622    38700      +78     
- Misses      40244    40283      +39     
- Partials     6249     6264      +15
Impacted Files Coverage Δ
routers/web/user/setting/security.go 30.30% <0.00%> (-2.49%) ⬇️
services/auth/source/oauth2/source_name.go 0.00% <0.00%> (ø)
services/auth/source/oauth2/source_register.go 0.00% <0.00%> (ø)
services/forms/auth_form.go 100.00% <ø> (ø)
services/auth/source/oauth2/urlmapping.go 27.58% <27.58%> (ø)
services/auth/source/oauth2/providers.go 26.66% <33.33%> (+21.49%) ⬆️
services/auth/source/oauth2/providers_simple.go 42.30% <42.30%> (ø)
services/auth/source/oauth2/providers_openid.go 53.33% <53.33%> (ø)
routers/web/admin/auths.go 48.72% <56.25%> (-1.46%) ⬇️
services/auth/source/oauth2/providers_custom.go 63.23% <63.23%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e6f23b...f629cd2. Read the comment docs.
@lafriks
lafriks reviewed Jul 25, 2021
View changes
services/auth/source/oauth2/providers_openid.go Show resolved Hide resolved
@lafriks
lafriks reviewed Jul 25, 2021
View changes
services/auth/source/oauth2/providers_simple.go Show resolved Hide resolved
@zeripath
zeripath reviewed Jul 25, 2021
View changes
services/auth/source/oauth2/providers_custom.go Show resolved Hide resolved
services/auth/source/oauth2/providers_openid.go Show resolved Hide resolved
services/auth/source/oauth2/providers_simple.go Show resolved Hide resolved
@zeripath
Apply suggestions from code review
2d7c289
@techknowlogick techknowlogick added this to the 1.16.0 milestone Jul 26, 2021
@lafriks
lafriks approved these changes Jul 26, 2021
View changes
@zeripath zeripath mentioned this pull request Jul 27, 2021
Closed
zeripath added 4 commits Jul 27, 2021
@zeripath
Merge branch 'main' into add-microsoft-oauth2-providers
7bb1b3f
@zeripath
remove unused Scopes
ca74bc0 
Signed-off-by: Andrew Thornton <[email protected]>
@zeripath
Merge remote-tracking branch 'origin/main' into add-microsoft-oauth2-…
5e59a7f 
…providers
@zeripath
Merge branch 'main' into add-microsoft-oauth2-providers
6b0f81a
@techknowlogick
techknowlogick approved these changes Aug 5, 2021
View changes
@techknowlogick
Merge branch 'main' into add-microsoft-oauth2-providers
9d3f807
@techknowlogick
Merge branch 'main' into add-microsoft-oauth2-providers
f629cd2
@techknowlogick techknowlogick merged commit ab9bb54 into go-gitea:main Aug 6, 2021
2 checks passed
2 checks passed
approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details
@zeripath zeripath deleted the zeripath:add-microsoft-oauth2-providers branch Aug 6, 2021
@zeripath zeripath mentioned this pull request Aug 6, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@techknowlogick techknowlogick

@lafriks lafriks

Assignees
No one assigned
Labels
kind/feature lgtm/done
Milestone
1.16.0
Linked issues

Successfully merging this pull request may close these issues.

AzureAD .well-known config is partially invalid, making OAuth2 registration with the "common" or "organizations" endpoints impossible
OAuth2 with MS Azure not working
5 participants
@zeripath @codecov-commenter @techknowlogick @lafriks @GiteaBot