Catch error when making axios request #83

mre · 2020-10-01T15:17:28Z

The request handling of this VSCode plugin is not handling errors at the moment.
Here is the request code:

Lines 99 to 110 in 370d427

    
             private async _doRequest(): Promise<AxiosResponse> { 
        
               let query = encodeURI(this.currQuery.replace(/ /g, "+")); 
        
               let url = this.getUrl(this.currLanguage, query); 
        
               let data = this.requestCache[url]; 
        
               if (data) { 
        
                 return data; 
        
               } 
        
               let res = await axios.get(url, this._requestConfig()); 
        
               this.requestCache[url] = res; 
        
               return res; 
        
             } 
        
           }

As you can see, we don't check for errors in line 106.
It would be great to catch errors there and show and error message to the user.
You can test this by going offline and searching for a snippet. In this case it should show an error message (and not silently fail).

Fixing this issue will probably help troubleshooting #77, so there is some real user value.

brew-install-buzzwords · 2020-10-01T15:24:21Z

Hi, I can take this issue if it's still available

mre · 2020-10-01T15:28:27Z

Sure. Assigning to you. Thanks! 😊

mre added good first issue hacktoberfest help wanted labels Oct 1, 2020

mre assigned brew-install-buzzwords Oct 1, 2020

Nov	JAN	May
	05
2020	2021	2022

mre / vscode-snippet

Catch error when making axios request #83

Catch error when making axios request #83

mre commented Oct 1, 2020

brew-install-buzzwords commented Oct 1, 2020

mre commented Oct 1, 2020

mre / vscode-snippet

Sponsor mre/vscode-snippet

Catch error when making axios request #83

Catch error when making axios request #83

Comments

mre commented Oct 1, 2020

brew-install-buzzwords commented Oct 1, 2020

mre commented Oct 1, 2020