The Wayback Machine - https://web.archive.org/web/20211014030619/https://github.com/pytorch/pytorch/pull/61311
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --jobs 0 for git submodule update (#61152) #61311

Closed
wants to merge 1 commit into from
Closed

Add --jobs 0 for git submodule update (#61152) #61311

wants to merge 1 commit into from

Conversation

@zhouzhuojie
Copy link
Member

@zhouzhuojie zhouzhuojie commented Jul 6, 2021

Summary:
Pull Request resolved: #61152

Some related docs about submodule.fetchJobs
https://git-scm.com/docs/git-config#Documentation/git-config.txt-submodulefetchJobs

time git submodule update --init --recursive
________________________________________________________
Executed in  243.20 secs    fish           external
   usr time   49.64 secs  213.00 micros   49.64 secs
   sys time   29.27 secs  795.00 micros   29.27 secs

time git submodule update --init --recursive --jobs 4
________________________________________________________
Executed in  143.04 secs    fish           external
   usr time   51.06 secs  246.00 micros   51.06 secs
   sys time   30.96 secs  742.00 micros   30.96 secs

time git submodule update --init --recursive --jobs 8
________________________________________________________
Executed in  124.64 secs    fish           external
   usr time   51.76 secs  264.00 micros   51.76 secs
   sys time   30.49 secs  739.00 micros   30.49 secs


time git submodule update --init --recursive --jobs 0 # use all online cpus
 ________________________________________________________
Executed in  129.75 secs    fish           external
   usr time   51.64 secs  181.00 micros   51.64 secs
   sys time   31.49 secs  781.00 micros   31.49 secs

Test Plan: Imported from OSS

Differential Revision: D29560875

Pulled By: zhouzhuojie
@facebook-github-bot
Copy link
Contributor

@facebook-github-bot facebook-github-bot commented Jul 6, 2021 •
edited

💊 CI failures summary and remediations

As of commit cde6cf9 (more details on the Dr. CI page and at hud.pytorch.org/pr/61311):

  • 1/2 failures introduced in this PR
  • 1/2 broken upstream at merge base 7a4ffbd on Jul 06 from 4:02pm to 10:49pm

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See GitHub Actions build Linux CI (pytorch-linux-bionic-py3.8-gcc9-coverage) / build (1/1)

Step: "Build PyTorch" (full log | diagnosis details | 🔁 rerun)

2021-07-07T00:49:37.5594865Z Build left local git repository checkout dirty 
2021-07-07T00:49:37.5583289Z ?? test/.coverage.19b3659a337f.25848.007499
2021-07-07T00:49:37.5584270Z ?? test/.coverage.19b3659a337f.25899.516563
2021-07-07T00:49:37.5585381Z ?? test/.coverage.19b3659a337f.25947.957032
2021-07-07T00:49:37.5586408Z ?? test/.coverage.19b3659a337f.25962.863751
2021-07-07T00:49:37.5588435Z ?? test/.coverage.19b3659a337f.25975.208153
2021-07-07T00:49:37.5589471Z ?? test/.coverage.19b3659a337f.25987.771638
2021-07-07T00:49:37.5590496Z ?? test/.coverage.19b3659a337f.26009.017187
2021-07-07T00:49:37.5591696Z ?? test/.coverage.jit.1625618936.190827
2021-07-07T00:49:37.5592632Z ?? test/.coverage.jit.1625618974.9337783 ]]
2021-07-07T00:49:37.5593945Z + echo 'Build left local git repository checkout dirty'
2021-07-07T00:49:37.5594865Z Build left local git repository checkout dirty
2021-07-07T00:49:37.5595795Z + echo 'git status --porcelain:'
2021-07-07T00:49:37.5596569Z git status --porcelain:
2021-07-07T00:49:37.5597583Z + echo '?? test/.coverage.19b3659a337f.25780.721083
2021-07-07T00:49:37.5598610Z ?? test/.coverage.19b3659a337f.25824.118862
2021-07-07T00:49:37.5599622Z ?? test/.coverage.19b3659a337f.25836.425091
2021-07-07T00:49:37.5600627Z ?? test/.coverage.19b3659a337f.25848.007499
2021-07-07T00:49:37.5601604Z ?? test/.coverage.19b3659a337f.25899.516563
2021-07-07T00:49:37.5602625Z ?? test/.coverage.19b3659a337f.25947.957032
2021-07-07T00:49:37.5603637Z ?? test/.coverage.19b3659a337f.25962.863751
2021-07-07T00:49:37.5604654Z ?? test/.coverage.19b3659a337f.25975.208153

🚧 1 fixed upstream failure:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

If your commit is older than viable/strict, run these commands:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

Preview docs built from this PR

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot
Copy link
Contributor

@facebook-github-bot facebook-github-bot commented Jul 6, 2021

This pull request was exported from Phabricator. Differential Revision: D29560875

@zhouzhuojie zhouzhuojie mentioned this pull request Jul 6, 2021
Closed
@zhouzhuojie zhouzhuojie requested a review from Jul 6, 2021
@facebook-github-bot
Copy link
Contributor

@facebook-github-bot facebook-github-bot commented Jul 6, 2021

This pull request was exported from Phabricator. Differential Revision: D29560875

@zhouzhuojie zhouzhuojie force-pushed the export-D29560875 branch from 940bdf7 to 95836e3 Jul 6, 2021
@zhouzhuojie @facebook-github-bot
Add --jobs 0 for git submodule update (pytorch#61311)
cde6cf9 
Summary:
Pull Request resolved: pytorch#61311

Pull Request resolved: pytorch#61152

Some related docs about `submodule.fetchJobs`
https://git-scm.com/docs/git-config#Documentation/git-config.txt-submodulefetchJobs

```
time git submodule update --init --recursive
________________________________________________________
Executed in  243.20 secs    fish           external
   usr time   49.64 secs  213.00 micros   49.64 secs
   sys time   29.27 secs  795.00 micros   29.27 secs
```

```
time git submodule update --init --recursive --jobs 4
________________________________________________________
Executed in  143.04 secs    fish           external
   usr time   51.06 secs  246.00 micros   51.06 secs
   sys time   30.96 secs  742.00 micros   30.96 secs
```

```
time git submodule update --init --recursive --jobs 8
________________________________________________________
Executed in  124.64 secs    fish           external
   usr time   51.76 secs  264.00 micros   51.76 secs
   sys time   30.49 secs  739.00 micros   30.49 secs

```

```
time git submodule update --init --recursive --jobs 0 # use all online cpus
 ________________________________________________________
Executed in  129.75 secs    fish           external
   usr time   51.64 secs  181.00 micros   51.64 secs
   sys time   31.49 secs  781.00 micros   31.49 secs

```

Test Plan: Imported from OSS

Reviewed By: 1ntEgr8

Differential Revision: D29560875

Pulled By: zhouzhuojie

fbshipit-source-id: 60180e7b8478a04e1df777f6f20a0590df8959c5
@facebook-github-bot
Copy link
Contributor

@facebook-github-bot facebook-github-bot commented Jul 7, 2021

This pull request was exported from Phabricator. Differential Revision: D29560875

@zhouzhuojie zhouzhuojie force-pushed the export-D29560875 branch from 95836e3 to cde6cf9 Jul 7, 2021
@facebook-github-bot
Copy link
Contributor

@facebook-github-bot facebook-github-bot commented Jul 7, 2021

@zhouzhuojie merged this pull request in 6107cf3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driazati driazati

Assignees
No one assigned
Labels
cla signed fb-exported Merged
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@zhouzhuojie @facebook-github-bot @driazati