Support system-provided Intel TBB #61934
Closed
Conversation
|
| Job | Step | Action |
|---|---|---|
 pytorch_cpp_doc_build |
Doc Build and Push | |
| pytorch_xla_linux_bionic_py3_6_clang9_test |
Run tests |
ci.pytorch.org: 1 failed
This comment was automatically generated by Dr. CI (expand for details).
Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group.
|
@cbalioglu has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@cbalioglu has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@cbalioglu merged this pull request in 7565039. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This PR: (1) enables the use of a system-provided Intel TBB for building PyTorch, (2) removes
tbb:task_scheduler_initreferences since it has been removed from TBB a while ago (3) marks the implementation of_internal_set_num_threadswith a TODO as it requires a revision that fixes its thread allocation logic.Tested with
test/run_test; no new tests are introduced since there are no behavioral changes (removal oftbb::task_scheduler_inithas no impact on the runtime behavior).