The Wayback Machine - https://web.archive.org/web/20210811103850/https://github.com/discourse/discourse/pull/10588
Skip to content

/ discourse

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEV: upgrades dev config #10588

Merged
merged 2 commits into from Sep 4, 2020
Merged

DEV: upgrades dev config #10588

merged 2 commits into from Sep 4, 2020

Conversation

@jjaffeux
Copy link
Contributor

@jjaffeux jjaffeux commented Sep 3, 2020 •
edited

This commit will do the following:

  • move everything related to eslint/prettier into eslint-config-discourse
  • add a local .prettierrc config
  • applies the new fixes of prettier, nots it's mostly wrapping single arg anon function into () and adding a space between function and ()
  • fixes two prettier offenses where Int8Array and Sinon where not present in the file, I suppose eslint couldn't search in comments before
  • moves bootbox global in discourse-ember
  • I removed trailingComma which is now enforced by prettier, no strong feelings on this

Note, for this commit to work we must first merge and publish new version of eslint-config-discourse discourse/eslint-config-discourse#8
@jjaffeux jjaffeux requested review from eviltrout, CvX and pmusaraj Sep 3, 2020
@pmusaraj
pmusaraj approved these changes Sep 3, 2020
View changes
@CvX
CvX approved these changes Sep 3, 2020
View changes
Copy link
Contributor

@CvX CvX left a comment

Huge diff but 👍.

I removed trailingComma which is now enforced by prettier, no strong feelings on this

I wouldn't mind enabling it. Makes some diffs cleaner (adding a line to a list is one line change instead of two 😛)
@eviltrout
eviltrout approved these changes Sep 3, 2020
View changes
Copy link
Member

@eviltrout eviltrout left a comment

I can't review 690 changes here but a quick glance looks OK.

As for bootbox, that is likely still used by plugins which is why I added it to core. If you assume it's linted by the eslint-config-discourse then plugin linting might fail.
@discoursereviewbot
Copy link

@discoursereviewbot discoursereviewbot commented Sep 3, 2020

Joffrey JAFFEUX posted:

I will make sure to add our eslint config on missing plugins
@jjaffeux
DEV: upgrades dev config
cc1089d
@jjaffeux jjaffeux force-pushed the jjaffeux:upgrades-dev-config branch from d8ddd3e to cc1089d Sep 4, 2020
@jjaffeux
Merge branch 'master' into upgrades-dev-config
2cbedb6
@jjaffeux jjaffeux merged commit 80dfaeb into discourse:master Sep 4, 2020
6 of 8 checks passed
6 of 8 checks passed
@github-actions
PLUGINS-BACKEND
Details
@github-actions
CORE-BACKEND
Details
@github-actions
PLUGINS-FRONTEND
Details
@github-actions
CORE-FRONTEND
Details
@github-actions
PLUGINS-LINT PLUGINS-LINT
Details
@github-actions
CORE-LINT CORE-LINT
Details
@lgtm-com
LGTM analysis: JavaScript No new or fixed alerts
Details
license/cla Contributor License Agreement is signed.
Details
@jjaffeux jjaffeux deleted the jjaffeux:upgrades-dev-config branch Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eviltrout eviltrout

@CvX CvX

@pmusaraj pmusaraj

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
5 participants
@jjaffeux @discoursereviewbot @eviltrout @CvX @pmusaraj