FIX: Do not dump schema during production database migrations #12785
Conversation
It's important that we don't perform pg_dumps against databases running behind pgbouncer. We had an old monkey-patch to prevent this, but following some [recent internal rails refactoring](rails/rails@5488686), the patch no longer works. Instead, we can use the official `config.active_record.dump_schema_after_migration` option. Setting this to false in production is recommended by Rails, and is the default for newly generated Rails applications.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
It's important that we don't perform pg_dumps against databases
running behind pgbouncer.
We had an old monkey-patch to prevent this, but following some recent
internal rails refactoring,
the patch no longer works. Instead, we can use the official
config.active_record.dump_schema_after_migrationoption.Setting this to false in production is recommended by Rails, and is the
default for newly generated Rails applications.