DEV: Remove PostProcessed trigger option
#13916
Merged
+17
−11
Conversation
It was deprecated 5 years ago in e55e2af
|
The person creating the enum might have thought at some point that a bit field made sense. Or perhaps we had one and migrated away from it but kept the values? Either way looks like we have to live with it. I would personally advise against re-using the value. I would recommend renaming it to |
|
I agree with @eviltrout, we should not allow this value to be reused anymore by assigning it to a "deprecated" variable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
It was deprecated 5 years ago in e55e2af
I've seen it still being used in the wild, even though it doesn't do anything anymore as I understand it.
@ZogStriP do you foresee any issues if
16would eventually be reused as a trigger value? E.g. are badge seeds executed before post_migrate? (so the one added here would override them on new forums?) If so, would it be better to make it a regular migration? Or to leave a comment "reserving" that value in the enum?(Also, it's weird we're using power of two values, since it's not a bit-field, i.e. only a single enum value can be active at a time)