The Wayback Machine - https://web.archive.org/web/20210811103627/https://github.com/discourse/discourse/pull/13971
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV: ignore the given_daily_likes table when moving timestamps on Try #13971

Conversation

@AndrewPrigorshnev
Copy link
Contributor

@AndrewPrigorshnev AndrewPrigorshnev commented Aug 6, 2021

This will fix the try-reset build that failed today. Probably this going to happen again with other tables that have constraints on date columns. I'm going to modify the script to make it work without ignoring such tables. After that, the only table we're going to need to ignore will be the 2FA table.

Before I fixed that, don't hesitate to tag me if the try-reset build fail again.

This will fix the try-reset build that failed today. Probably this
going to happen again with other tables that have constraints on date
columns. I'm going to modify the script to make it work without
ignoring such tables. After that, the only table we're going to need to ignore
will be the 2FA table.

Before I fixed that, don't hesitate to tag me if the try-reset build fail again.
@AndrewPrigorshnev AndrewPrigorshnev requested a review from davidtaylorhq Aug 6, 2021
@AndrewPrigorshnev AndrewPrigorshnev merged commit b66674f into main Aug 6, 2021
9 checks passed
9 checks passed
@github-actions
core backend
Details
@github-actions
plugins backend
Details
@github-actions
core frontend
Details
@github-actions
plugins frontend
Details
@github-actions
core annotations
Details
@lgtm-com
LGTM analysis: JavaScript No code changes detected
Details
license/cla Contributor License Agreement is signed.
Details
@AndrewPrigorshnev AndrewPrigorshnev deleted the dev/ignore-given-daily-likes-table-when-moving-timestamps-on-try branch Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants