Factorize box layout functions. #185
Merged
+143
−168
Conversation
|hbox| and |vbox| are similar. They are just the same component, but drawing in a different direction. This patchs factorize the layout logic. Goal is to reduce code size and reuse it for the |gridbox| dom element. Bug: #114
ArthurSonzogni
added a commit
that referenced
this pull request
Aug 10, 2021
This reverts commit 71299da.
ArthurSonzogni
added a commit
that referenced
this pull request
Aug 10, 2021
ArthurSonzogni
added a commit
that referenced
this pull request
Aug 10, 2021
This reverts commit a709597.
ArthurSonzogni
added a commit
that referenced
this pull request
Aug 10, 2021
This reverts commit a709597.
ArthurSonzogni
added a commit
that referenced
this pull request
Aug 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
|hbox| and |vbox| are similar. They are just the same component, but
drawing in a different direction.
This patchs factorize the layout logic. Goal is to reduce code size and
reuse it for the |gridbox| dom element.
Bug: #114