The Wayback Machine - https://web.archive.org/web/20210926100647/https://github.com/Moya/Moya/issues/1911
Skip to content

/ Moya Public

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Combine docs to the Readme #1911

Open
sunshinejr opened this issue Sep 6, 2019 · 3 comments
Open

Add Combine docs to the Readme #1911

sunshinejr opened this issue Sep 6, 2019 · 3 comments
Labels
documentation enhancement good first issue

Comments

@sunshinejr
Copy link
Member

@sunshinejr sunshinejr commented Sep 6, 2019

Basically add a readme section, similar to our Rx and Reactive sections but using the new publishers.
@sunshinejr
Copy link
Member Author

@sunshinejr sunshinejr commented Oct 5, 2019

Unfortunately have to close this one as we are removing Combine support for now.

@sunshinejr sunshinejr closed this Oct 5, 2019
@philipbel
Copy link

@philipbel philipbel commented Jul 22, 2020 •
edited

Now that Combine support is back in 15.0.0-alpha.1, this issue should probably be reopened?

@sunshinejr
Copy link
Member Author

@sunshinejr sunshinejr commented Jul 23, 2020

@philipbel yes good catch! though we have added some docs in #2024 and #2066, there might be still some work to look at all the docs and make sure we provide at least most of the things we provide for Rx/RAS docs

@sunshinejr sunshinejr reopened this Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation enhancement good first issue
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@philipbel @pedrovereza @sunshinejr