The Wayback Machine - https://web.archive.org/web/20250604162836/https://github.com/TheAlgorithms/C-Plus-Plus/pull/1436
Skip to content

feat : Reverse of string -- algorithm #1436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

feat : Reverse of string -- algorithm #1436

wants to merge 1 commit into from

Conversation

ayushbisht2001
Copy link

@ayushbisht2001 ayushbisht2001 commented Dec 14, 2020 •
edited by gitpod-io bot
Loading

Description of Change

I have added (i.e Reverse_string.cpp) an algorithm to get the reverse of any string.

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Panquesito7
Panquesito7 requested changes Dec 15, 2020
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is not up to the repository standards.
Please read them carefully and follow them.

@Panquesito7 Panquesito7 added automated tests are failing Do not merge until tests pass enhancement New feature or request Proper Documentation Required requested to write the documentation properly requested changes changes have been requested labels Dec 15, 2020
@abdoulayegk
Copy link

abdoulayegk commented Jun 20, 2021 •
edited
Loading

hey, your code didn't pass because you didn't use the correct format try to put spaces between variable like this:

    for (int i = 0; i < n; i++)
    {
        for (int j = 0; j < (n - i - 1); j++)
        {
            if (A[j] > A[j + 1])
            {
                int temp = A[j];
                A[j] = A[j + 1];
                A[j + 1] = temp;
            }
        }
    }
    std::cout << "The resultant array is: " << std::endl;
    for (int i = 0; i < n; i++)
    {
        std::cout << A[i] << std::endl;
    }
    return 0;
}

@Panquesito7 Panquesito7 added the stale Author has not responded to the comments for over 2 weeks label Jun 20, 2021
@stale
Copy link

stale bot commented Sep 6, 2021

Please ping one of the maintainers once you commit the changes requested or make improvements on the code. If this is not the case and you need some help, feel free to ask for help in our Gitter channel. Thank you for your contributions!

@stale stale bot closed this Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Panquesito7 Panquesito7 Panquesito7 requested changes

Assignees
No one assigned
Labels
automated tests are failing Do not merge until tests pass enhancement New feature or request Proper Documentation Required requested to write the documentation properly requested changes changes have been requested stale Author has not responded to the comments for over 2 weeks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ayushbisht2001 @abdoulayegk @Panquesito7