The Wayback Machine - https://web.archive.org/web/20220925000518/https://github.com/scala-js/scala-js/issues/4312
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make module tests independent of Node.js modules and testHtml them #4312

Closed
gzm0 opened this issue Dec 4, 2020 · 0 comments · Fixed by #4318
Closed

Make module tests independent of Node.js modules and testHtml them #4312

gzm0 opened this issue Dec 4, 2020 · 0 comments · Fixed by #4318
Assignees
@gzm0
Labels
enhancement Feature request (that does not concern language semantics, see "language") internal Not visible to users of Scala.js (only by devs in this repo)
Milestone
v1.4.0

Comments

@gzm0
Copy link
Contributor

gzm0 commented Dec 4, 2020

No description provided.

@gzm0 gzm0 added enhancement Feature request (that does not concern language semantics, see "language") internal Not visible to users of Scala.js (only by devs in this repo) labels Dec 4, 2020
@gzm0 gzm0 added this to the v1.4.0 milestone Dec 4, 2020
@gzm0 gzm0 self-assigned this Dec 4, 2020
gzm0 added a commit to gzm0/scala-js that referenced this issue Dec 4, 2020
@gzm0
Fix scala-js#4311: Do not move input files in HTMLRunnerBuilder
425e693 
It is unclear to me why I thought this is necessary in the first
place.

We leave the scalaJSTestHTMLArtifactDirectory key/settings in place
since they do not hurt and removing will break compatibility.

Further, we add a section to TESTING to test ES module support in the
browser (the full testSuite is not in there yet, due to scala-js#4312).
gzm0 added a commit to gzm0/scala-js that referenced this issue Dec 4, 2020
@gzm0
Fix scala-js#4311: Do not move input files in HTMLRunnerBuilder
da2f863 
It is unclear to me why I thought this is necessary in the first
place.

We leave the scalaJSTestHTMLArtifactDirectory key/settings in place
since they do not hurt and removing will break compatibility.

Further, we add a section to TESTING to test ES module support in the
browser (the full testSuite is not in there yet, due to scala-js#4312).
gzm0 added a commit to gzm0/scala-js that referenced this issue Dec 4, 2020
@gzm0
Fix scala-js#4311: Do not move input files in HTMLRunnerBuilder
c648b05 
It is unclear to me why I thought this is necessary in the first
place.

We leave the scalaJSTestHTMLArtifactDirectory key/settings in place
since they do not hurt and removing will break compatibility.

Further, we add a section to TESTING to test ES module support in the
browser (the full testSuite is not in there yet, due to scala-js#4312).
@gzm0 gzm0 mentioned this issue Dec 4, 2020
Merged
gzm0 added a commit to gzm0/scala-js that referenced this issue Dec 4, 2020
@gzm0
Fix scala-js#4311: Avoid to move input files in HTMLRunnerBuilder
64f8ba4 
We directly refer to an input if it is on the same filesystem than the
output/artifactsDir.

Further, we add a section to TESTING to test ES module support in the
browser (the full testSuite is not in there yet, due to scala-js#4312).
gzm0 added a commit to gzm0/scala-js that referenced this issue Dec 4, 2020
@gzm0
Fix scala-js#4311: Avoid moving input files in HTMLRunnerBuilder
de6af4b 
We directly refer to an input if it is on the same filesystem than the
output/artifactsDir.

Further, we add a section to TESTING to test ES module support in the
browser (the full testSuite is not in there yet, due to scala-js#4312).
gzm0 added a commit to gzm0/scala-js that referenced this issue Dec 4, 2020
@gzm0
Fix scala-js#4311: Avoid moving input files in HTMLRunnerBuilder
721be23 
We directly refer to an input if it is on the same filesystem than the
output/artifactsDir.

Further, we add a section to TESTING to test ES module support in the
browser (the full testSuite is not in there yet, due to scala-js#4312).
gzm0 added a commit to gzm0/scala-js that referenced this issue Dec 5, 2020
@gzm0
Fix scala-js#4311: Avoid moving input files in HTMLRunnerBuilder
da3f9d0 
We directly refer to an input if it is on the same filesystem than the
output/artifactsDir.

Further, we add a section to TESTING to test ES module support in the
browser (the full testSuite is not in there yet, due to scala-js#4312).
gzm0 added a commit to gzm0/scala-js that referenced this issue Dec 7, 2020
@gzm0
Fix scala-js#4312: Make testSuite/testHtml work with modules
d2fbf0a 
The only missing piece is global object detection.
gzm0 added a commit to gzm0/scala-js that referenced this issue Dec 7, 2020
@gzm0
Fix scala-js#4312: Make testSuite/testHtml work with modules
a8d4b4c 
The only missing piece is global object detection.
@gzm0 gzm0 linked a pull request Dec 7, 2020 that will close this issue
Fix #4312: Make testSuite/testHtml work with modules #4318
Merged
gzm0 added a commit to gzm0/scala-js that referenced this issue Dec 7, 2020
@gzm0
Fix scala-js#4312: Make testSuite/testHtml work with modules
9d721d2 
The only missing piece is global object detection.
gzm0 added a commit to gzm0/scala-js that referenced this issue Dec 8, 2020
@gzm0
Fix scala-js#4312: Make testSuite/testHtml work with modules
334633b 
The only missing piece is global object detection.
gzm0 added a commit to gzm0/scala-js that referenced this issue Dec 8, 2020
@gzm0
Fix scala-js#4312: Make testSuite/testHtml work with modules
dcfd993 
The only missing piece is global object detection.
@gzm0 gzm0 closed this as completed in #4318 Dec 8, 2020
gzm0 added a commit that referenced this issue Dec 8, 2020
@gzm0
Merge pull request #4318 from gzm0/test-own-modules
cbb82a5 
Fix #4312: Make testSuite/testHtml work with modules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gzm0 gzm0

Labels
enhancement Feature request (that does not concern language semantics, see "language") internal Not visible to users of Scala.js (only by devs in this repo)
Projects
None yet
Milestone
v1.4.0
Development

Successfully merging a pull request may close this issue.

Fix #4312: Make testSuite/testHtml work with modules gzm0/scala-js
1 participant
@gzm0