The Wayback Machine - https://web.archive.org/web/20201020112034/https://github.com/go-sql-driver/mysql/pull/962
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add support for OK packets representing EOF #962

Open
wants to merge 1 commit into
base: master
from

Conversation

@nemith
Copy link
Contributor

@nemith nemith commented May 1, 2019

Fixes: #805

Description

Please explain the changes you made here.

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary
  • Added myself / the copyright holder to the AUTHORS file
@nemith
Copy link
Contributor Author

@nemith nemith commented May 2, 2019

Submitting early for early review and ideas for better testing.

There are some areas where no EOF or OK will be sent when DEPRECATED_EOF is set which make this a bit less trivial.

@julienschmidt julienschmidt added this to the v1.5.0 milestone May 7, 2019
@julienschmidt julienschmidt modified the milestones: v1.5.0, v1.6.0 Sep 30, 2019
@tz70s
Copy link

@tz70s tz70s commented Aug 30, 2020

Hello @nemith is this still working? If not, do you mind me take over this?

@nemith
Copy link
Contributor Author

@nemith nemith commented Sep 1, 2020

Hello @nemith is this still working? If not, do you mind me take over this?

Please take over. I don't have any time to work on it now.

@tz70s tz70s mentioned this pull request Sep 5, 2020
1 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.