Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upadd audioPlayers plugin to readMe - edited source #504
Conversation
|
Hi, |
|
Hi, I resolved any conflicts within the branches. Please merge it if possile. |
|
Hey @subhash279 I noticed its an improved fork but is there any particular reason it wasn't contributed back to the original repository? |
|
Hi @jogboms I am not sure actually why this wasn't merged. It doesn't even have any merge conflicts. Can you pls merge it if possible. Thanks. |
|
Hey @subhash279 I mean, at this point, I know both libraries have diverged much but I was just wondering as a fork, why it was never merged back to the source as a PR instead of an entirely new library sharing literally the same name? PS. you didn't author the library, I know. |
|
Hi @jogboms I am not entirely sure as you said I am not the author and only a contributor. But I think this has many more features than the original one and I think lots of code was rewritten as well. |
|
True. I added the label to look more into it. Thanks |
|
@jogboms thanks. Also as you may have already noticed it already has more than 460 stars on its own as a new repo. |
|
True @subhash279 with a bit more open issues too :) |
Hi,
This plugin provides a simple way to play multiple audio files simultaneously on android and ios. The examples are here - https://github.com/luanpotter/audioplayers.
Many features like setting playback rate, showing audio in notification area for ios are available.
I think it will be useful to lot of people.
I edited the source file according to the guidelines now.
Thanks,