The Wayback Machine - https://web.archive.org/web/20210901024237/https://github.com/papercups-io/papercups/issues/816
Skip to content

/ papercups

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better phone number filtering for twillio and SMS in integrations page #816

Open
cheeseblubber opened this issue May 5, 2021 · 3 comments
Open

Better phone number filtering for twillio and SMS in integrations page #816

cheeseblubber opened this issue May 5, 2021 · 3 comments
Assignees
@cheeseblubber
Labels
enhancement good first issue

Comments

@cheeseblubber
Copy link
Contributor

@cheeseblubber cheeseblubber commented May 5, 2021

Problem
Right now if you enter a phone number without the area code or have the wrong formatting in phone number section it will fail silently and not work. We should make sure that there is a country code and that it can work regardless of the text formatting

Screen Shot 2021-05-05 at 5 30 52 PM

Solution
It should validate that it has a country code and we shouldn't care about formatting
@cheeseblubber
Copy link
Contributor Author

@cheeseblubber cheeseblubber commented May 5, 2021

@a8t you might have some context on this

@a8t
Copy link
Contributor

@a8t a8t commented May 5, 2021 •
edited

Twilio has a free phone number validator service that we already use for something else. Maybe we can also pair with a client-side validation. (is a phone number regex stupid?)

link dump
https://www.twilio.com/blog/international-phone-number-input-html-javascript

https://www.twilio.com/docs/lookup/tutorials/validation-and-formatting#format-an-international-phone-number

https://www.twilio.com/docs/lookup/tutorials/validation-and-formatting#validate-a-national-phone-number

@cheeseblubber
Copy link
Contributor Author

@cheeseblubber cheeseblubber commented May 6, 2021

Yeah I think just some client side validation + string formatting would be ideal. It doesn't work if we add spaces in to the phone number

@cheeseblubber cheeseblubber self-assigned this May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cheeseblubber cheeseblubber

Labels
enhancement good first issue
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@cheeseblubber @a8t