The Wayback Machine - https://web.archive.org/web/20210813030928/https://github.com/localstack/localstack/pull/4424
Skip to content

/ localstack

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add new event logging system #4424

Merged
merged 22 commits into from Aug 10, 2021
Merged

add new event logging system #4424

merged 22 commits into from Aug 10, 2021
+1,012 −202

Conversation

@thrau
Copy link
Member

@thrau thrau commented Aug 9, 2021

this PR adds new facilities for logging localstack events
@thrau thrau requested a review from whummer Aug 9, 2021
@whummer
whummer approved these changes Aug 9, 2021
View changes
Copy link
Member

@whummer whummer left a comment

Looks awesome @thrau 🚀 - super excited to get these changes in!
localstack/utils/analytics/client.py Outdated Show resolved Hide resolved
localstack/utils/analytics/logger.py Outdated Show resolved Hide resolved
localstack/utils/analytics/metadata.py Show resolved Hide resolved
thrau added 21 commits Jul 23, 2021
@thrau
wip: add initial abstractions
187c656
@thrau
remove old profiler code
603f1a0
@thrau
add first draft of analytics logging abstractions and tests
550d7c6
@thrau
add dataclasses requirement for python3.6 compat
b129575
@thrau
add is_testing flag to analytics metadata
4952a19
@thrau
disable tracking for internal test runs
b878f57
@thrau
add flush interval to publisherbuffer
049ed04
@thrau
add global analytics EventLogger
b9a9728
@thrau
enable JsonHttpPublisher by default
adebbf7
@thrau
add python version marker for dataclasses dependency
7ea9f5a
@thrau
add new api constant and properly flush at close
4c97791
@thrau
pull out event name from eventmetadata to first-class attribute
a3f560e
@thrau
restructure global analytics bus into separate class
97c0284
@thrau
log API calls and infra startup with services
fd3584b
@thrau
update analytics bus to register asynchronously
25c056f
@thrau
log legacy events into new analytics service
1b47391
@thrau
set analytics api to production endpoint
761f967
@thrau
analytics cmd indicators in PublisherBuffer to strings
1429be4
@thrau
fix nits
d70b6fb
@thrau
do not log api calls for now
d896418
@thrau
update Dockerfile to remove dataclasses py3.6 compat dependency
50bcc1f
@thrau thrau force-pushed the analytics-v2 branch from c05dec2 to 50bcc1f Aug 10, 2021
@coveralls
Copy link

@coveralls coveralls commented Aug 10, 2021 •
edited

Coverage Status

Coverage increased (+0.4%) to 80.382% when pulling 2148f5a on analytics-v2 into 2d1e9ca on master.
@thrau
add git hash to version string
2148f5a
@thrau thrau merged commit 0941f1d into master Aug 10, 2021
7 checks passed
7 checks passed
ci/circleci: docker-build Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: itest-elasticmq Your tests passed on CircleCI!
Details
ci/circleci: itest-lambda-docker Your tests passed on CircleCI!
Details
ci/circleci: preflight Your tests passed on CircleCI!
Details
ci/circleci: report Your tests passed on CircleCI!
Details
coverage/coveralls Coverage increased (+0.4%) to 80.382%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whummer whummer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@thrau @coveralls @whummer