The Wayback Machine - https://web.archive.org/web/20210619043622/https://github.com/kubernetes/kubernetes/issues/102545
Skip to content

/ kubernetes

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of duplicate set of metrics for watch counts #102545

Open
shyamjvs opened this issue Jun 2, 2021 · 6 comments
Open

Get rid of duplicate set of metrics for watch counts #102545

shyamjvs opened this issue Jun 2, 2021 · 6 comments
Assignees
@logicalhan @sanwishe
Labels
good first issue help wanted kind/bug sig/instrumentation triage/accepted

Comments

@shyamjvs
Copy link
Member

@shyamjvs shyamjvs commented Jun 2, 2021 •
edited

Just noticed that we have redundant metrics for watch counts like:

# HELP apiserver_longrunning_gauge [ALPHA] Gauge of all active long-running apiserver requests broken out by verb, group, version, resource, scope and component. Not all requests are tracked this way.
# TYPE apiserver_longrunning_gauge gauge
apiserver_longrunning_gauge{component="apiserver",group="",resource="configmaps",scope="cluster",subresource="",verb="WATCH",version="v1"}
 1
apiserver_longrunning_gauge{component="apiserver",group="",resource="configmaps",scope="namespace",subresource="",verb="WATCH",version="v1"} 25

^ This was added in v1.9 as part of #52302

# HELP apiserver_registered_watchers [ALPHA] Number of currently registered watchers for a given resources
# TYPE apiserver_registered_watchers gauge
apiserver_registered_watchers{group="",kind="ConfigMap",version="v1"} 26

^ This was added in v1.11 as part of #63779

We probably should get rid of the latter since the former is more granular and also includes other long-running calls (like proxy). Both seem to be in alpha status FWIW.

/cc @wojtek-t @smarterclayton (authors for those changes)
/sig instrumentation
/good-first-issue
@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Jun 2, 2021

@shyamjvs:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

Just noticed that we have redundant metrics for watch counts like:

# HELP apiserver_longrunning_gauge [ALPHA] Gauge of all active long-running apiserver requests broken out by verb, group, version, resource, scope and component. Not all requests are tracked this way.
# TYPE apiserver_longrunning_gauge gauge
apiserver_longrunning_gauge{component="apiserver",group="",resource="configmaps",scope="cluster",subresource="",verb="WATCH",version="v1"}
1
apiserver_longrunning_gauge{component="apiserver",group="",resource="configmaps",scope="namespace",subresource="",verb="WATCH",version="v1"} 25

^ This was added in v1.9 as part of #52302

# HELP apiserver_registered_watchers [ALPHA] Number of currently registered watchers for a given resources
# TYPE apiserver_registered_watchers gauge
apiserver_registered_watchers{group="",kind="ConfigMap",version="v1"} 26

^ This was added in v1.11 as part of #63779

We probably should get rid of the latter since the former is more granular and also includes other long-running calls (like proxy). Both seem to be in alpha status FWIW.

/cc @wojtek-t @smarterclayton
/sig instrumentation
/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@sanwishe
Copy link
Contributor

@sanwishe sanwishe commented Jun 2, 2021

/assign
@vineelyalamarthy
Copy link

@vineelyalamarthy vineelyalamarthy commented Jun 3, 2021

/assign
@sanwishe
Copy link
Contributor

@sanwishe sanwishe commented Jun 3, 2021

@vineelyalamarthy Thank you very much for assigning. but I’ve already working on this issue. It is a pleasure to working with you next time?
/unassign vineelyalamarthy
@sanwishe sanwishe mentioned this issue Jun 4, 2021
Open
@wojtek-t
Copy link
Member

@wojtek-t wojtek-t commented Jun 7, 2021

Being addressed in #102595
@logicalhan
Copy link
Contributor

@logicalhan logicalhan commented Jun 16, 2021

/triage accepted
/assign
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@logicalhan logicalhan

@sanwishe sanwishe

Labels
good first issue help wanted kind/bug sig/instrumentation triage/accepted
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
@vineelyalamarthy @logicalhan @shyamjvs @wojtek-t @sanwishe @k8s-ci-robot