add browser option to config #3992
Merged
Conversation
Allows setting the path to the browser using the config. Closes #858
despreston
force-pushed the
despreston:858-config-browser
branch
from
79fe649
to
c95f30a
|
Thanks for the contribution! I added some tests and a little |
| // Browser precedence | ||
| // 1. browser from config | ||
| // 2. BROWSER | ||
| func browserLauncher(f *cmdutil.Factory) string { |
samcoe
Aug 17, 2021
Member
I extracted this function from browser for testability purposes.
I extracted this function from browser for testability purposes.
|
This is all excellent. Thank you both! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Allows setting the path to the browser using the config.
Closes #858