Skip to content

Updated templates to avoid the LaunchEngine #169998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 10, 2025

Conversation

gaaclarke
Copy link
Member

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@gaaclarke gaaclarke requested a review from a team as a code owner June 4, 2025 16:16
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@gaaclarke gaaclarke marked this pull request as draft June 4, 2025 16:16
@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jun 4, 2025
@gaaclarke gaaclarke marked this pull request as ready for review June 4, 2025 17:20
@gaaclarke
Copy link
Member Author

@hellohuanlin @vashworth friendly ping. I think I sent this out when the iOS team had some meetings.

Copy link
Contributor

@vashworth vashworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaaclarke gaaclarke added this pull request to the merge queue Jun 6, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Jun 6, 2025
@gaaclarke gaaclarke force-pushed the pluginregistrant-template branch from 6a7c6c9 to e0bc399 Compare June 6, 2025 17:31
@gaaclarke gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 6, 2025
Copy link
Contributor

auto-submit bot commented Jun 6, 2025

autosubmit label was removed for flutter/flutter/169998, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 6, 2025
@gaaclarke gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 6, 2025
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 6, 2025
Copy link
Contributor

auto-submit bot commented Jun 6, 2025

autosubmit label was removed for flutter/flutter/169998, because - The status or check suite Linux web_long_running_tests_3_5 has failed. Please fix the issues identified (or deflake) before re-applying this label.

@gaaclarke gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 8, 2025
Copy link
Contributor

auto-submit bot commented Jun 8, 2025

autosubmit label was removed for flutter/flutter/169998, because - The status or check suite Linux web_long_running_tests_3_5 has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 8, 2025
@gaaclarke
Copy link
Member Author

rerunning Linux web_long_running_tests_3_5

@gaaclarke
Copy link
Member Author

Linux web_long_running_tests_3_5 failed again, merging master

@gaaclarke gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 9, 2025
Copy link
Contributor

auto-submit bot commented Jun 9, 2025

autosubmit label was removed for flutter/flutter/169998, because - The status or check suite Linux customer_testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 9, 2025
@gaaclarke gaaclarke force-pushed the pluginregistrant-template branch from 20a6242 to 5cf8556 Compare June 10, 2025 01:02
@gaaclarke
Copy link
Member Author

rebased to before 2eec076 to avoid a bogus roll

@gaaclarke gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 10, 2025
Copy link
Contributor

auto-submit bot commented Jun 10, 2025

autosubmit label was removed for flutter/flutter/169998, because - The status or check suite Linux tool_integration_tests_1_7 has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 10, 2025
@gaaclarke gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 10, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Jun 10, 2025
Merged via the queue into flutter:master with commit 8483f1a Jun 10, 2025
146 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 10, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants