-
Notifications
You must be signed in to change notification settings - Fork 28.7k
Updated templates to avoid the LaunchEngine #169998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated templates to avoid the LaunchEngine #169998
Conversation
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
@hellohuanlin @vashworth friendly ping. I think I sent this out when the iOS team had some meetings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
6a7c6c9
to
e0bc399
Compare
autosubmit label was removed for flutter/flutter/169998, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
autosubmit label was removed for flutter/flutter/169998, because - The status or check suite Linux web_long_running_tests_3_5 has failed. Please fix the issues identified (or deflake) before re-applying this label. |
autosubmit label was removed for flutter/flutter/169998, because - The status or check suite Linux web_long_running_tests_3_5 has failed. Please fix the issues identified (or deflake) before re-applying this label. |
rerunning Linux web_long_running_tests_3_5 |
Linux web_long_running_tests_3_5 failed again, merging master |
autosubmit label was removed for flutter/flutter/169998, because - The status or check suite Linux customer_testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
20a6242
to
5cf8556
Compare
rebased to before 2eec076 to avoid a bogus roll |
autosubmit label was removed for flutter/flutter/169998, because - The status or check suite Linux tool_integration_tests_1_7 has failed. Please fix the issues identified (or deflake) before re-applying this label. |
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.